Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] Support R 4.2 #4881

Closed
Tracked by #5153
jameslamb opened this issue Dec 12, 2021 · 4 comments · Fixed by #5503
Closed
Tracked by #5153

[R-package] Support R 4.2 #4881

jameslamb opened this issue Dec 12, 2021 · 4 comments · Fixed by #5503

Comments

@jameslamb
Copy link
Collaborator

Summary

R 4.2 is going to include some significant changes to how packages are built on Windows. I've created this "feature request" to document those changes in this project's backlog and so that we have something to link conversations to if users report issues on R 4.2.x, but R 4.2 has not yet been released.

Motivation

{lightgbm}, the R package for LightGBM, should continue to work with new versions of R.

Description

See https://developer.r-project.org/Blog/public/2021/12/07/upcoming-changes-in-r-4.2-on-windows/. This was shared by Tomas Kalibera on the r-pkg-devel mailing list.

Some notable quotes

R 4.2 for Windows will support UTF-8 as native encoding

...will require at least Windows 10 (version 1903) on desktop systems, Windows Server 2022 on long-term support server systems or Windows Server 1903 from the semi-annual channel

R 4.2 will also drop support for 32-bit builds on Windows

A new compiler toolchain, RTools42, will be used for building Windows binaries of R and R packages from source

According to that blog post, there is now support for testing on R Hub with the UCRT toolchain. See https://builder.r-hub.io/advanced.

Screen Shot 2021-12-11 at 10 57 30 PM

So I think it would be useful to add a new comment-triggered workflow, similar to the existing Solaris one.

https://github.com/microsoft/LightGBM/blob/80662618996431c222e6c92cbba7e784f8a935cd/.github/workflows/r_solaris.yml

References

Since March of this year, CRAN has been running checks with this toolchain on existing packages. {lightgbm} is currently passing those checks without WARNINGs or ERRORs!

https://cran.r-project.org/web/checks/check_results_lightgbm.html

Screen Shot 2021-12-11 at 11 00 18 PM

@jameslamb
Copy link
Collaborator Author

Linking this helpful doc that was mentioned on the r-pkg-devel mailing list this week: https://cran.r-project.org/bin/windows/base/howto-R-4.2.html

@jameslamb
Copy link
Collaborator Author

R 4.2 will be released on April 22 (11 days from now): https://developer.r-project.org/

@StrikerRUS
Copy link
Collaborator

StrikerRUS commented Apr 12, 2022

With logs reported in #5140, we have an evidence that LightGBM can be successfully compiled for the R-4.2.0alpha.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity since it was closed.
To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues
including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants