Convert Utilities to Shared Project #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on refactoring the project structure related to the
Utilitiesproject. TheUtilities.csprojproject was removed and replaced with a shared project. These changes address a discrepancy that can occur on version of the Microsoft.Performance.SDK toolkit used in the dependents.Project Reference Changes:
LTTngCds/LTTngCds.csproj: Removed project reference toUtilities.csprojand added import ofUtilities.projitems.LTTngDataExtensions/LTTngDataExtensions.csproj: Removed project reference toUtilities.csprojand added import ofUtilities.projitems. [1] [2]LinuxLogParsers/LinuxLogParser/LinuxLogParser.csproj: Removed project reference toUtilities.csprojand added import ofUtilities.projitems. [1] [2]PerfDataExtension/PerfDataExtension.csproj: Removed project reference toUtilities.csprojand added import ofUtilities.projitems.PerfDataTxtExtension/PerfDataTxtExtension.csproj: Removed project reference toUtilities.csprojand added import ofUtilities.projitems. [1] [2]PerfettoCds/PerfettoCds.csproj: Removed project reference toUtilities.csprojand added import ofUtilities.projitems. [1] [2]PerfettoProcessor/PerfettoProcessor.csproj: Removed project reference toUtilities.csprojand added import ofUtilities.projitems. [1] [2]Solution File Changes:
Microsoft-Perf-Tools-Linux-Android.sln: RemovedUtilities.csprojfrom the solution and addedUtilities.shproj. Also, removed and added some configurations related to theUtilitiesproject. [1] [2] [3] [4]Utilities Project Changes:
Utilities/Utilities.csproj: Removed this file.Utilities/Utilities.projitems: Added this file which includes shared code.Utilities/Utilities.shproj: Added this file which is a shared project file.