Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to Import PowerSTIG 4.4.0 Due to cyclic dependency Error #617

Merged
merged 18 commits into from
May 19, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
updated module load process for VMware modules
  • Loading branch information
erjenkin committed May 13, 2020
commit eb79ada18c205f3d1da76b4b461137d2ab73fd05
7 changes: 7 additions & 0 deletions Tests/Integration/Module/PowerStig.Integration.tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,11 @@ Describe "$moduleName module" {
$compare.Count | Should Be 0
}
}

Context 'Import PowerSTIG should not throw' {

It "Should not throw and error" {
Import-Module PowerSTIG | Should -Not -Throw
}
}
}
34 changes: 21 additions & 13 deletions build.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -234,19 +234,27 @@ Begin
}
}

InvokeBuild = 'latest'
PSScriptAnalyzer = 'latest'
Pester = 'latest'
Plaster = 'latest'
ModuleBuilder = '1.0.0'
ChangelogManagement = 'latest'
Sampler = '0.104.0'
xDSCResourceDesigner = 'latest'
PSPKI = 'latest'
MarkdownLinkCheck = 'latest'
'DscResource.Test' = 'latest'
'DscResource.AnalyzerRules' = 'latest'
'powershell-yaml' = 'latest'
InvokeBuild = 'latest'
PSScriptAnalyzer = 'latest'
Pester = 'latest'
Plaster = 'latest'
ModuleBuilder = '1.0.0'
ChangelogManagement = 'latest'
Sampler = '0.104.0'
xDSCResourceDesigner = 'latest'
PSPKI = 'latest'
MarkdownLinkCheck = 'latest'
'DscResource.Test' = 'latest'
'DscResource.AnalyzerRules' = 'latest'
'powershell-yaml' = 'latest'
'VMware.VimAutomation.Sdk' = '12.0.0.15939651'
'VMware.VimAutomation.Common' = '12.0.0.15939652'
'VMware.Vim' = '7.0.0.15939650'
'VMware.VimAutomation.Cis.Core' = '12.0.0.15939657'
'VMware.VimAutomation.Core' = '12.0.0.15939655'
'VMware.VimAutomation.Storage' = '12.0.0.15939648'
'VMware.VimAutomation.Vds' = '12.0.0.15940185'
'Vmware.vSphereDsc' = '2.1.0.58'
# The modules below are dynamically inserted from the Begin block of .\build.ps1

'@
Expand Down
27 changes: 27 additions & 0 deletions source/Module/PowerStig.ModuleHelper.ps1
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
#This script was created to get around a cyclic redundancy error that is present in PowerShell 5.
#When importing PowerSTIG with the following modules listed as required modules in the manifest the error occurs
#Link to the issue - https://github.com/PowerShell/PowerShell/issues/2607

$requiredmodules = @(
@{ModuleName = 'VMware.VimAutomation.Sdk'; ModuleVersion = '12.0.0.15939651'}
@{ModuleName = 'VMware.VimAutomation.Common'; ModuleVersion = '12.0.0.15939652'}
@{ModuleName = 'VMware.Vim'; ModuleVersion ='7.0.0.15939650'}
@{ModuleName = 'VMware.VimAutomation.Cis.Core'; ModuleVersion = '12.0.0.15939657'}
@{ModuleName = 'VMware.VimAutomation.Core'; ModuleVersion = '12.0.0.15939655'}
@{ModuleName = 'VMware.VimAutomation.Storage'; ModuleVersion = '12.0.0.15939648'}
@{ModuleName = 'VMware.VimAutomation.Vds'; ModuleVersion = '12.0.0.15940185'}
@{ModuleName = 'Vmware.vSphereDsc'; ModuleVersion = '2.1.0.58'}
)

foreach($module in $requiredmodules)
{
if(Get-Module -ListAvailable -Name $module.ModuleName)
{
import-module -Name $module.ModuleName -version $module.ModuleVersion -ErrorAction Stop
}
else
{
Write-Error -Message "$($module.ModuleName) Version: $($module.ModuleVersion) is not installed, please install and try again."
break
}
}
10 changes: 3 additions & 7 deletions source/PowerStig.psd1
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,6 @@ RequiredModules = @(
@{ModuleName = 'WindowsDefenderDsc'; ModuleVersion = '1.0.0.0'},
@{ModuleName = 'xDnsServer'; ModuleVersion = '1.11.0.0'},
@{ModuleName = 'xWebAdministration'; ModuleVersion = '2.5.0.0'}
@{ModuleName = 'VMware.VimAutomation.Sdk'; ModuleVersion = '12.0.0.15939651'}
@{ModuleName = 'VMware.VimAutomation.Common'; ModuleVersion = '12.0.0.15939652'}
@{ModuleName = 'VMware.Vim'; ModuleVersion ='7.0.0.15939650'}
@{ModuleName = 'VMware.VimAutomation.Cis.Core'; ModuleVersion = '12.0.0.15939657'}
@{ModuleName = 'VMware.VimAutomation.Core'; ModuleVersion = '12.0.0.15939655'}
@{ModuleName = 'VMware.VimAutomation.Storage'; ModuleVersion = '12.0.0.15939648'}
@{ModuleName = 'VMware.VimAutomation.Vds'; ModuleVersion = '12.0.0.15940185'}
)

# DSC resources to export from this module
Expand Down Expand Up @@ -97,6 +90,9 @@ VariablesToExport = @()
# Aliases to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no aliases to export.
AliasesToExport = @()

# Script files (.ps1) that are run in the caller's environment prior to importing this module.
ScriptsToProcess = '.\Module\PowerStig.ModuleHelper.ps1'

# Private data to pass to the module specified in RootModule/ModuleToProcess. This may also contain a PSData hashtable with additional module metadata used by PowerShell.
PrivateData = @{

Expand Down