Don't implicit-any diagnostic for json module #27376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ////import abs = require([|"foo/bar.json"|]); | ||
| ////abs; | ||
|
|
||
| verify.noErrors(); |
There was a problem hiding this comment.
How come? There should be error in node_modules/foo/bar.json because this is not json?
ghost
force-pushed
the
codeFixCannotFindModule_suggestion_falsePositive
branch
from
8a4fe21
to
7b1388b
Compare
ghost
assigned 
sheetalkamat
approved these changes
Nov 16, 2018
sheetalkamat
deleted the
codeFixCannotFindModule_suggestion_falsePositive
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would wrongly issue a diagnostic saying the the module is implicitly
any.