More permissive parsing of instantiation expressions #48659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
| // Treat anything else as an expression. | ||
| return false; | ||
| // Consider something a type argument list only if the following token can't start an expression. | ||
| return !isStartOfExpression(); |
There was a problem hiding this comment.
I'm always surprised that this function exists and doesn't fall out of date in some catastrophic way.
There was a problem hiding this comment.
Oh, we'd know right away. For example, in when parsing argument lists or array literal elements, we require it to return true before each element (it's called from isListElement which is called from parseList).
DanielRosenwasser
approved these changes
Apr 12, 2022
This was referenced Apr 14, 2022
Jack-Works
pushed a commit
to Jack-Works/TypeScript
that referenced
this pull request
Apr 22, 2022
* More permissive parsing of expressions with type arguments * Add test
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48654.