Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that perf_hooks result actually contains the performance object #59300

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

jakebailey
Copy link
Member

@jakebailey jakebailey commented Jul 16, 2024

I guess some environments polyfill this with {} or something. Only use the module if performance is there. This broke in #57875.

Fixes #59296

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jul 16, 2024
@jakebailey
Copy link
Member Author

@typescript-bot cherry-pick this to release-5.5

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 16, 2024

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
cherry-pick this to release-5.5 ✅ Started ✅ Results

@typescript-bot
Copy link
Collaborator

Hey, @jakebailey! I've created #59301 for you.

@jakebailey jakebailey merged commit bd54a6b into microsoft:main Jul 16, 2024
29 checks passed
@jakebailey jakebailey deleted the fix-59296 branch July 16, 2024 17:03
DanielRosenwasser pushed a commit that referenced this pull request Jul 16, 2024
…e-5.5 (#59301)

Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

tryGetPerformanceHooks throws on Stackblitz with ts 5.5.3
3 participants