Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix loadAsset function in 6-space-game/2-drawing-to-canvas/README.md #78

Merged
merged 1 commit into from
Nov 26, 2020
Merged

fix loadAsset function in 6-space-game/2-drawing-to-canvas/README.md #78

merged 1 commit into from
Nov 26, 2020

Commits on Nov 21, 2020

  1. fix loadAsset function in example code 

    1. move `resolve(img)` in loadAsset function to the inside of the img.onload function to resolve the promise after the image is loaded
2. remove the async keyword of loadAsset because it is not that harmful but not yet necessary
    @qgp9
    qgp9 committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    37f3626 View commit details
    Browse the repository at this point in the history