Prevent running multiple instances of Clarity simultaneously #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toby-walker
reviewed
Aug 4, 2021
| const c = 'clarity'; | ||
|
|
||
| // Do not execute or reset global "clarity" variable if a version of Clarity is already running on the page | ||
| if (w[c] && w[c].v) { return console.warn("Error CL001: Multiple Clarity tags detected."); } |
There was a problem hiding this comment.
Can we instrument this with a custom variable or event?
And, even better, grab a stack trace?
toby-walker
reviewed
Aug 4, 2021
| while (queue.length > 0) { w.clarity(...queue.shift()); } | ||
| const c = 'clarity'; | ||
|
|
||
| // Do not execute or reset global "clarity" variable if a version of Clarity is already running on the page |
There was a problem hiding this comment.
Can we track the project id that is also running and then figure out which project id is the source of the duplication?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set a "v" property on the global clarity variable so we can look for it before running a second instance.