Use latest googletest for builds on macOS 11.0 or higher #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalitb
requested review from
bliptec,
kindbe,
larvacea,
maxgolov,
mkoscumb,
reyang and
sid-dahiya
as code owners
lalitb
changed the title
…_telemetry into macos-11-googletest
|
@sid-dahiya @reyang Can you please approve this PR. As GH virtual machines for macOS are upgraded from 10.15 to 11.6, the CI pipeline is failing. This PR fixes to use the latest googletest from submodule/clone for ubuntu 20.04 and macOS 11.x, and existing older from /googletest for other platforms. For #994 which tries to upgrade googletest for all the platforms, let's discuss it before, as it may break build for older platforms not part of CI and which we still support. The CI pipeline is sometimes failing for #969 (segfault while running c-api tests), which I will address separately. |
…_telemetry into macos-11-googletest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed over 1ds.sdk.cpp channel in Teams, the functional/unit tests are currently failing for the latest macOS version. The clang compiler on this OS is perhaps not happy with the older version of google-test brought as part of this repo. This PR ensures that we use the latest google-test version for macOS 11.0 or higher.
The older gtest/gmock version is coming from: https://github.com/microsoft/cpp_client_telemetry/tree/main/googletest .
The latest gtest/gmock version is used from third_party/googletest ( either cloned as submodule or else downloaded and copied in that path during build)
Note: github VM for
macos-latestpoints tomacos-10.15, so the problem is not caught in our CI pipeline.