Use example-data package and fix other example imports #10280

ecraig12345 · 2019-08-27T05:42:19Z

Pull request checklist

Include a change request file using $ yarn change

Description of changes

Fix example imports:

Use the new @uifabric/example-data package everywhere that was previously using the old example data files
Deprecate example data exports from example-app-base (anyone using these should switch to the example-data package)
Remove all remaining relative imports
Remove "deep" imports where possible
Remove direct imports from packages re-exported from OUFR

And the corresponding updates to the lint-imports script:

Remove remaining relative import exceptions (except scss files)
Check for "deep" imports (with an exception list of files that aren't exported anywhere)
Check for direct imports from packages re-exported from OUFR (based on a hardcoded list)

And other example-related issues:

Update codepen-loader to work with the new package
Fix some incorrectly-named examples in charting and experiments
Add index files and a root-level file for SelectedItemsList to facilitate getting rid of deep imports

Microsoft Reviewers: Open in CodeFlow

msft-github-bot · 2019-08-27T06:14:57Z

Component Perf Analysis

No significant results to display.

All results

Scenario	Master Ticks	PR Ticks
BaseButton	820	790
BaseButton (experiments)	1044	1054
DefaultButton	1082	1074
DefaultButton (experiments)	2057	2068
DetailsRow	3486	3461
DetailsRow (fast icons)	3472	3486
DetailsRow without styles	3157	3252
DocumentCardTitle with truncation	34750	34654
MenuButton	1401	1433
MenuButton (experiments)	3680	3639
PrimaryButton	1230	1268
PrimaryButton (experiments)	2131	2132
SplitButton	2979	2975
SplitButton (experiments)	7301	7315
Stack	503	521
Stack with Intrinsic children	1207	1203
Stack with Text children	4519	4484
Text	393	412
Toggle	907	935
Toggle (experiments)	2383	2349
button	57	70

packages/example-app-base/src/components/CodepenComponent/CodepenComponent.tsx

ecraig12345 · 2019-08-27T23:24:35Z

Marking as do not merge while I resolve an issue with the codepen loader.

JasonGore · 2019-08-28T18:06:15Z

scripts/tasks/lint-imports.js

-const importStatementRegex = /^import [{} a-zA-Z0-9_,*\r?\n ]*(?:from )?['"]{1}([.\/a-zA-Z0-9_@\-]+)['"]{1};.*$/;
-const pkgNameRegex = /^(@[a-z\-]+\/[a-z\-]+)|([a-z\-]+)/;
+const importStatementGlobalRegex = /^import [^'"]*(?:from )?['"]([^'"]+)['"];.*$/gm;
+const importStatementRegex = /^import [^'"]*(?:from )?['"]([^'"]+)['"];.*$/;


Is there a fix here or is this just optimization of the same searches? (I'm sure you've tested but wanted to make sure they were still working.)

Optimization. Based on running the script and on these tests it seems to work fine. https://regex101.com/r/XWQ4Eq/1

JasonGore · 2019-08-28T18:07:13Z

scripts/tasks/lint-imports.js

+    '@uifabric/merge-styles': 'Styling',
+    '@uifabric/styling': 'Styling',
+    '@uifabric/utilities': 'Utilities'
+  };


KevinTCoughlin · 2019-08-28T18:50:49Z

Thanks for mentioning:

Don't export old example data helpers from example-app-base (anyone using these can switch to the example-data package)

I'll have to update our Fabric 7 + ODSP branch to reflect the above change.

KevinTCoughlin

The removal of data exports from example-app-base is a breaking change for consumers (ODSP). Can we leave the export removal for at least a major release?

ecraig12345 · 2019-08-28T20:10:32Z

The removal of data exports from example-app-base is a breaking change for consumers (ODSP). Can we leave the export removal for at least a major release?

I can revert that part--though those things arguably shouldn't have been exported to begin with, and example-app-base has never had the same API stability guarantees as our primary libraries. (I finally updated the example-app-base readme to note that.)

size-auditor · 2019-08-29T22:37:33Z

Asset size changes

Project	Bundle	Baseline Size	New Size	Difference
office-ui-fabric-react	ExtendedPicker	86.916 kB	86.181 kB	-735 bytes

Over Tolerance (1024 B) Over Baseline Below Baseline New Removed 1 kB = 1000 B

Baseline commit: 7a493e8a0915fd826cef36e70891979d09ca9b46 (build)

msft-github-bot · 2019-08-30T12:31:13Z

🎉@uifabric/experiments@v7.13.5 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot · 2019-08-30T12:31:13Z

🎉office-ui-fabric-react@v7.28.3 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot · 2019-08-30T12:31:20Z

🎉@uifabric/example-app-base@v7.6.3 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot · 2019-08-30T12:31:22Z

🎉@uifabric/codepen-loader@v7.0.8 has been released which incorporates this pull request.:tada:

Handy links:

ecraig12345 added 8 commits August 26, 2019 18:44

Use example-data in vr-tests

b3dbe90

Remove example data exports from example-app-base

541b82c

Update codepen-loader to work with new package

a0c708c

Fix SelectedItemsList export structure and example imports

513eb86

Fix experiments example imports

b31ad02

Use example data and fix imports in OUFR

9e64d64

Update lint-imports script to handle new rules

b3952ba

Change files

c3b9a01

ecraig12345 requested review from aditima, atneik, dzearing, Jahnp, JasonGore, jdhuntington, joschect, kenotron, KevinTCoughlin, Markionium, micahgodbolt, mtennoe, srideshpande, ThomasMichon, Vitalius1 and yiminwu as code owners August 27, 2019 05:42

msft-github-bot added the PR: API Modified label Aug 27, 2019

msft-github-bot assigned kenotron Aug 27, 2019

ecraig12345 added Area: Build System Area: Documentation labels Aug 27, 2019

kenotron approved these changes Aug 27, 2019

View reviewed changes

ecraig12345 added 2 commits August 27, 2019 15:28

Merge branch 'master' into example-data-2

4cc433c

Fix export to codepen

d4cce90

kenotron reviewed Aug 27, 2019

View reviewed changes

packages/example-app-base/src/components/CodepenComponent/CodepenComponent.tsx Show resolved Hide resolved

ecraig12345 added the Status: Do Not Merge 🚫 label Aug 27, 2019

Codepen enhancements

98d76f3

ecraig12345 removed the Status: Do Not Merge 🚫 label Aug 27, 2019

JasonGore reviewed Aug 28, 2019

View reviewed changes

JasonGore approved these changes Aug 28, 2019

View reviewed changes

KevinTCoughlin requested changes Aug 28, 2019

View reviewed changes

msft-github-bot added the Needs: Author Feedback label Aug 28, 2019

msft-github-bot removed the Needs: Author Feedback label Aug 28, 2019

Restore example data exports but mark as deprecated

81f59ee

aditima approved these changes Aug 28, 2019

View reviewed changes

lists shouldn't have production dep on example-app-base

b504357

KevinTCoughlin approved these changes Aug 28, 2019

View reviewed changes

Merge branch 'master' into example-data-2

de321ea

ecraig12345 merged commit 899983a into microsoft:master Aug 29, 2019

ecraig12345 deleted the example-data-2 branch August 29, 2019 23:09

KevinTCoughlin mentioned this pull request Oct 28, 2019

[Breaking change] Move @uifabric/example-app to devDependency and remove re-exports in office-ui-fabric-react #10977

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use example-data package and fix other example imports #10280

Use example-data package and fix other example imports #10280

ecraig12345 commented Aug 27, 2019 •

edited

Loading

msft-github-bot commented Aug 27, 2019 •

edited

Loading

ecraig12345 commented Aug 27, 2019

JasonGore Aug 28, 2019

ecraig12345 Aug 28, 2019

JasonGore Aug 28, 2019

KevinTCoughlin commented Aug 28, 2019 •

edited

Loading

KevinTCoughlin left a comment

ecraig12345 commented Aug 28, 2019

size-auditor bot commented Aug 29, 2019

msft-github-bot commented Aug 30, 2019

msft-github-bot commented Aug 30, 2019

msft-github-bot commented Aug 30, 2019

msft-github-bot commented Aug 30, 2019

Use example-data package and fix other example imports #10280

Use example-data package and fix other example imports #10280

Conversation

ecraig12345 commented Aug 27, 2019 • edited Loading

Pull request checklist

Description of changes

Microsoft Reviewers: Open in CodeFlow

msft-github-bot commented Aug 27, 2019 • edited Loading

Component Perf Analysis

ecraig12345 commented Aug 27, 2019

JasonGore Aug 28, 2019

Choose a reason for hiding this comment

ecraig12345 Aug 28, 2019

Choose a reason for hiding this comment

JasonGore Aug 28, 2019

Choose a reason for hiding this comment

KevinTCoughlin commented Aug 28, 2019 • edited Loading

KevinTCoughlin left a comment

Choose a reason for hiding this comment

ecraig12345 commented Aug 28, 2019

size-auditor bot commented Aug 29, 2019

Asset size changes

msft-github-bot commented Aug 30, 2019

msft-github-bot commented Aug 30, 2019

msft-github-bot commented Aug 30, 2019

msft-github-bot commented Aug 30, 2019

ecraig12345 commented Aug 27, 2019 •

edited

Loading

msft-github-bot commented Aug 27, 2019 •

edited

Loading

KevinTCoughlin commented Aug 28, 2019 •

edited

Loading