Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing the bump of intra-monorepo-packages for private packages #10285

Merged
merged 2 commits into from
Aug 27, 2019

Conversation

kenotron
Copy link
Member

@kenotron kenotron commented Aug 27, 2019

Pull request checklist

  • Include a change request file using $ yarn change

Description of changes

A bug was introduced in a recent change in beachball that made it not update private packages deps. This bumps beachball and fixes the cases where this breaks.

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

@msft-github-bot
Copy link
Contributor

Component Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Status
BaseButton 807 804
BaseButton (experiments) 1036 1060
DefaultButton 1060 1053
DefaultButton (experiments) 1964 1985
DetailsRow 3348 3481
DetailsRow (fast icons) 3383 3475
DetailsRow without styles 3193 3210
DocumentCardTitle with truncation 33586 33860
MenuButton 1424 1352
MenuButton (experiments) 3604 3592
PrimaryButton 1220 1241
PrimaryButton (experiments) 2101 2112
SplitButton 2971 2913
SplitButton (experiments) 7251 7266
Stack 518 498
Stack with Intrinsic children 1166 1166
Stack with Text children 4375 4357
Text 398 411
Toggle 905 911
Toggle (experiments) 2324 2319
button 57 60

@kenotron kenotron merged commit 3a6fe90 into microsoft:master Aug 27, 2019
@kenotron kenotron deleted the private branch August 27, 2019 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants