Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog: update demo text #10298

Merged
merged 2 commits into from
Aug 29, 2019
Merged

Dialog: update demo text #10298

merged 2 commits into from
Aug 29, 2019

Conversation

maxwellred
Copy link
Contributor

@maxwellred maxwellred commented Aug 28, 2019 •
edited by msft-github-bot
Loading

Pull request checklist

  • Addresses Teams conversation here:
  • Include a change request file using $ yarn change

Description of changes

Change demo text to match real OWA test per request

Before

Screen Shot 2019-08-28 at 12 39 02 PM

After

Screen Shot 2019-08-28 at 12 39 39 PM

Microsoft Reviewers: Open in CodeFlow

@msft-github-bot
Copy link
Contributor

Component Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Status
BaseButton 836 819
BaseButton (experiments) 1078 1155
DefaultButton 1099 1116
DefaultButton (experiments) 2106 2088
DetailsRow 3655 3600
DetailsRow (fast icons) 3576 3538
DetailsRow without styles 3313 3365
DocumentCardTitle with truncation 35612 34884
MenuButton 1457 1486
MenuButton (experiments) 3731 3722
PrimaryButton 1353 1283
PrimaryButton (experiments) 2141 2146
SplitButton 3034 3108
SplitButton (experiments) 7572 7626
Stack 530 535
Stack with Intrinsic children 1212 1233
Stack with Text children 4757 4575
Text 406 433
Toggle 991 938
Toggle (experiments) 2506 2446
button 65 76

kenotron
kenotron reviewed Aug 29, 2019
View reviewed changes
Copy link
Member

@kenotron kenotron left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kenotron kenotron merged commit e88ff3e into microsoft:master Aug 29, 2019
@maxwellred
Copy link
Contributor Author

Thanks @kenotron !

@msft-github-bot
Copy link
Contributor

🎉office-ui-fabric-react@v7.28.3 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenotron kenotron kenotron approved these changes

@kkjeer kkjeer Awaiting requested review from kkjeer

Assignees

@kenotron kenotron

Labels
Component: Dialog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxwellred @msft-github-bot @kenotron @mahendrareddyMSFT