Website: Added PopupMenu and BottomSheet to mobile docs #10325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c-react into update-mobile-controls
Component Perf AnalysisNo significant results to display. All results
|
williamado
suggested changes
Aug 30, 2019
apps/fabric-website/src/pages/Controls/BottomSheetPage/docs/android/BottomSheetOverview.md
Outdated
Show resolved
Hide resolved
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 801bf1eaecd186555cf00e38cd294c1bf7914c7d (build) |
|
@ecraig12345 - this doc looks okay but probably need your expertise in site. |
Jahnp
approved these changes
Aug 30, 2019
ecraig12345
reviewed
Aug 30, 2019
apps/fabric-website/src/SiteDefinition/SiteDefinition.pages/Controls/android.tsx
Show resolved
Hide resolved
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Added two new controls to the Android docs: PopupMenu and BottomSheet.
Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow