Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dropdownItem style override of azure-themes. #10333

Merged
merged 4 commits into from
Sep 4, 2019

Conversation

chenxinyanc
Copy link
Contributor

@chenxinyanc chenxinyanc commented Sep 2, 2019

Pull request checklist

Description of changes

Fixed dropdownItem style (especially background color) override for azure-themes.

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

@size-auditor
Copy link

size-auditor bot commented Sep 2, 2019

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: b18896736df5d3140a2cac94b68779bd07186334 (build)

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Sep 2, 2019

Component Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Status
BaseButton 853 815
BaseButton (experiments) 1149 1150
DefaultButton 1166 1171
DefaultButton (experiments) 2141 2191
DetailsRow 3620 3634
DetailsRow (fast icons) 3677 3624
DetailsRow without styles 3460 3362
DocumentCardTitle with truncation 35319 35319
MenuButton 1505 1482
MenuButton (experiments) 3984 3952
PrimaryButton 1327 1364
PrimaryButton (experiments) 2244 2264
SplitButton 3198 3137
SplitButton (experiments) 7917 7825
Stack 564 527
Stack with Intrinsic children 1232 1231
Stack with Text children 4756 4778
Text 412 399
Toggle 956 937
Toggle (experiments) 2497 2572
button 64 62

Copy link
Contributor

@maxwellred maxwellred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @chenxinyanc! Everything looks good but I have some nit change file formatting requests when you get a moment.

@dzearing dzearing merged commit 2c27658 into microsoft:master Sep 4, 2019
@msft-github-bot
Copy link
Contributor

🎉@uifabric/azure-themes@v7.0.8 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown box with AzureCustomizationsLight shows incorrect selection color
4 participants