Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export DetailsRowFields for rowFieldsAs #10772

Merged
merged 3 commits into from
Oct 10, 2019
Merged

Export DetailsRowFields for rowFieldsAs #10772

merged 3 commits into from
Oct 10, 2019

Conversation

KevinTCoughlin
Copy link
Member

@KevinTCoughlin KevinTCoughlin commented Oct 9, 2019 •
edited by msft-github-bot
Loading

Pull request checklist

Description of changes

Exports DetailsRowFields to be used via OUFR public API for rowFieldsAs prop.

Focus areas to test

  • CI should pass.

cc: @brandonthomas

Microsoft Reviewers: Open in CodeFlow

@KevinTCoughlin KevinTCoughlin mentioned this pull request Oct 9, 2019
Closed
@size-auditor
Copy link

size-auditor bot commented Oct 9, 2019

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react DetailsList 206.046 kB 206.094 kB ExceedsBaseline     48 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: 31396ed419c2cb91201af257e0e26a6d7307428f (build)

ecraig12345
ecraig12345 approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@ecraig12345 ecraig12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@msft-github-bot
Copy link
Contributor

Component Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Status
BaseButton 722 723
BaseButton (experiments) 1020 1005
DefaultButton 1014 994
DefaultButton (experiments) 2003 2049
DetailsRow 3156 3261
DetailsRow (fast icons) 3158 3164
DetailsRow without styles 2941 3002
DocumentCardTitle with truncation 31717 31003
MenuButton 1357 1324
MenuButton (experiments) 3602 3527
PrimaryButton 1172 1193
PrimaryButton (experiments) 2036 2075
SplitButton 2761 2751
SplitButton (experiments) 7195 7054
Stack 483 512
Stack with Intrinsic children 1112 1133
Stack with Text children 4372 4359
Text 386 362
Toggle 825 834
Toggle (experiments) 2356 2299
button 66 58

@msft-github-bot
Copy link
Contributor

Hello @KevinTCoughlin!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 30 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msft-github-bot) and give me an instruction to get started! Learn more here.

@msft-github-bot msft-github-bot merged commit 794a552 into microsoft:master Oct 10, 2019
@msft-github-bot
Copy link
Contributor

🎉office-ui-fabric-react@v7.48.0 has been released which incorporates this pull request.:tada:

Handy links:

@KevinTCoughlin KevinTCoughlin deleted the keco/detailsrowfields branch January 2, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecraig12345 ecraig12345 ecraig12345 approved these changes

Assignees

@khmakoto khmakoto

Labels
AutoMerge Component: DetailsList PR: API Modified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DetailsRowFields isn't exported at the package root
4 participants
@KevinTCoughlin @msft-github-bot @ecraig12345 @khmakoto