Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introducing the the heat map chart #15296

Merged
merged 15 commits into from
Oct 1, 2020
Merged

introducing the the heat map chart #15296

merged 15 commits into from
Oct 1, 2020

Conversation

shivasai09
Copy link
Contributor

Pull request checklist

Description of changes

added the new chart heat map
image
image

Focus areas to test

Heat Map

@msft-github-bot msft-github-bot added the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Sep 29, 2020
@shivasai09 shivasai09 closed this Sep 29, 2020
@shivasai09 shivasai09 reopened this Sep 29, 2020
@msft-github-bot
Copy link
Contributor

msft-github-bot commented Sep 29, 2020 •
edited
Loading

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
Avatar mount 931 934 5000
BaseButton mount 1017 995 5000
Breadcrumb mount 44297 43164 5000
ButtonNext mount 633 612 5000
Checkbox mount 1762 1747 5000
CheckboxBase mount 1465 1466 5000
ChoiceGroup mount 5286 5412 5000
ComboBox mount 1004 993 1000
CommandBar mount 8209 8076 1000
ContextualMenu mount 13854 13798 1000
DefaultButton mount 1262 1283 5000
DetailsRow mount 4017 3892 5000
DetailsRowFast mount 3955 4022 5000
DetailsRowNoStyles mount 3731 3770 5000
Dialog mount 1636 1594 1000
DocumentCardTitle mount 1906 1926 1000
Dropdown mount 2806 2788 5000
FocusTrapZone mount 1798 1858 5000
FocusZone mount 1873 1882 5000
IconButton mount 1981 1939 5000
Label mount 364 365 5000
Layer mount 2145 2142 5000
Link mount 477 500 5000
MenuButton mount 1638 1610 5000
MessageBar mount 2169 2169 5000
Nav mount 3545 3547 1000
OverflowSet mount 1543 1498 5000
Panel mount 1550 1546 1000
Persona mount 903 918 1000
Pivot mount 1556 1534 1000
PrimaryButton mount 1419 1375 5000
Rating mount 8405 8422 5000
SearchBox mount 1433 1464 5000
Shimmer mount 2909 2839 5000
Slider mount 1607 1618 5000
SpinButton mount 5468 5439 5000
Spinner mount 467 465 5000
SplitButton mount 3485 3502 5000
Stack mount 611 575 5000
StackWithIntrinsicChildren mount 2139 2069 5000
StackWithTextChildren mount 5569 5567 5000
SwatchColorPicker mount 11150 11296 5000
TagPicker mount 2926 2988 5000
TeachingBubble mount 52390 52468 5000
Text mount 463 467 5000
TextField mount 1503 1501 5000
ThemeProvider mount 3330 3294 5000
ThemeProvider virtual-rerender 638 629 5000
Toggle mount 933 905 5000
button mount 126 113 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.51 0.53 0.96:1 2000 1020
🦄 Button.Fluent 0.13 0.22 0.59:1 5000 666
🔧 Checkbox.Fluent 0.71 0.38 1.87:1 1000 706
🎯 Dialog.Fluent 0.18 0.25 0.72:1 5000 914
🔧 Dropdown.Fluent 3.15 0.53 5.94:1 1000 3153
🔧 Icon.Fluent 0.16 0.07 2.29:1 5000 816
🎯 Image.Fluent 0.1 0.13 0.77:1 5000 479
🔧 Slider.Fluent 1.67 0.39 4.28:1 1000 1671
🔧 Text.Fluent 0.08 0.04 2:1 5000 422
🦄 Tooltip.Fluent 0.13 16.93 0.01:1 5000 635

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 184 0 Infinity:1
AlertMinimalPerf.default 361 0 Infinity:1
AnimationMinimalPerf.default 476 0 Infinity:1
AttachmentMinimalPerf.default 204 0 Infinity:1
AttachmentSlotsPerf.default 1260 0 Infinity:1
AvatarMinimalPerf.default 559 0 Infinity:1
BoxMinimalPerf.default 488 0 Infinity:1
ButtonMinimalPerf.default 222 0 Infinity:1
ButtonOverridesMissPerf.default 1866 0 Infinity:1
ButtonSlotsPerf.default 689 0 Infinity:1
ButtonUseCssPerf.default 929 0 Infinity:1
ButtonUseCssNestingPerf.default 1223 0 Infinity:1
CarouselMinimalPerf.default 563 0 Infinity:1
ChatMinimalPerf.default 722 0 Infinity:1
ChatWithPopoverPerf.default 538 0 Infinity:1
CheckboxMinimalPerf.default 3188 0 Infinity:1
DividerMinimalPerf.default 465 0 Infinity:1
DropdownManyItemsPerf.default 864 0 Infinity:1
EmbedMinimalPerf.default 2192 0 Infinity:1
FlexMinimalPerf.default 346 0 Infinity:1
FormMinimalPerf.default 519 0 Infinity:1
GridMinimalPerf.default 422 0 Infinity:1
HeaderSlotsPerf.default 914 0 Infinity:1
ImageMinimalPerf.default 474 0 Infinity:1
InputMinimalPerf.default 1444 0 Infinity:1
LabelMinimalPerf.default 518 0 Infinity:1
LayoutMinimalPerf.default 495 0 Infinity:1
ListCommonPerf.default 772 0 Infinity:1
ListMinimalPerf.default 585 0 Infinity:1
ListNestedPerf.default 679 0 Infinity:1
LoaderMinimalPerf.default 835 0 Infinity:1
MenuMinimalPerf.default 972 0 Infinity:1
MenuButtonMinimalPerf.default 1781 0 Infinity:1
PopupMinimalPerf.default 830 0 Infinity:1
PortalMinimalPerf.default 188 0 Infinity:1
RadioGroupMinimalPerf.default 553 0 Infinity:1
ReactionMinimalPerf.default 483 0 Infinity:1
RefMinimalPerf.default 262 0 Infinity:1
SegmentMinimalPerf.default 427 0 Infinity:1
SkeletonMinimalPerf.default 533 0 Infinity:1
SplitButtonMinimalPerf.default 4254 0 Infinity:1
StatusMinimalPerf.default 859 0 Infinity:1
IconMinimalPerf.default 788 0 Infinity:1
TableManyItemsPerf.default 2558 0 Infinity:1
TableMinimalPerf.default 511 0 Infinity:1
TextAreaMinimalPerf.default 614 0 Infinity:1
TooltipMinimalPerf.default 938 0 Infinity:1
TreeMinimalPerf.default 1039 0 Infinity:1
TreeWith60ListItems.default 233 0 Infinity:1
VideoMinimalPerf.default 731 0 Infinity:1
Avatar.Fluent 1020 0 Infinity:1
Button.Fluent 666 0 Infinity:1
Dialog.Fluent 914 0 Infinity:1
Dropdown.Fluent 3153 0 Infinity:1
Icon.Fluent 816 0 Infinity:1
Image.Fluent 479 0 Infinity:1
Slider.Fluent 1671 0 Infinity:1
Text.Fluent 422 0 Infinity:1
Tooltip.Fluent 635 0 Infinity:1
CustomToolbarPrototype.default 4189 1 4189:1
DropdownMinimalPerf.default 3138 1 3138:1
ProviderMergeThemesPerf.default 2197 1 2197:1
SliderMinimalPerf.default 1682 1 1682:1
ItemLayoutMinimalPerf.default 1488 1 1488:1
ToolbarMinimalPerf.default 1109 1 1109:1
ProviderMinimalPerf.default 1080 1 1080:1
ListWith60ListItems.default 1044 1 1044:1
DialogMinimalPerf.default 903 1 903:1
Checkbox.Fluent 706 1 706:1
CardMinimalPerf.default 651 1 651:1
ChatDuplicateMessagesPerf.default 476 1 476:1
HeaderMinimalPerf.default 463 1 463:1
TextMinimalPerf.default 435 1 435:1

@size-auditor
Copy link

size-auditor bot commented Sep 29, 2020 •
edited
Loading

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: 4069d50

Possible causes

  • The baseline build 4069d50 is broken
  • The Size Auditor run for the baseline build 4069d50 was not triggered

Recommendations

  • Please merge your branch for this Pull request with the latest master build and commit your changes once again

@shivasai09 shivasai09 closed this Sep 29, 2020
@shivasai09 shivasai09 reopened this Sep 29, 2020
@khmakoto khmakoto mentioned this pull request Sep 29, 2020
Closed
40 tasks
@shivasai09 shivasai09 closed this Sep 30, 2020
@shivasai09 shivasai09 reopened this Sep 30, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 1, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8c4d600:

Sandbox Source
Fluent UI Button Configuration
microsoft/fluentui: codesandbox-react-template Configuration
microsoft/fluentui: codesandbox-react-next-template Configuration
microsoft/fluentui: codesandbox-react-northstar-template Configuration

@shivasai09 shivasai09 closed this Oct 1, 2020
@shivasai09 shivasai09 reopened this Oct 1, 2020
@Raghurk Raghurk merged commit 6bf22de into microsoft:7.0 Oct 1, 2020
@msft-github-bot
Copy link
Contributor

🎉@fluentui/react-examples@v0.4.5 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot msft-github-bot mentioned this pull request Oct 2, 2020
Closed
@msft-github-bot
Copy link
Contributor

🎉@uifabric/charting@v4.4.0 has been released which incorporates this pull request.:tada:

Handy links:

@khmakoto khmakoto mentioned this pull request Oct 22, 2020
Merged
2 tasks
ecraig12345 pushed a commit that referenced this pull request Oct 23, 2020
@khmakoto
Charting: Implementing HeatMapChart and introducing some APIs in Cart…
8bd76d7 
…esianChart to support it (#15664)

Cherry-pick of #15296.
SethDonohue pushed a commit to SethDonohue/fluentui that referenced this pull request Nov 2, 2020
@khmakoto
Charting: Implementing HeatMapChart and introducing some APIs in Cart…
6e8a5bc 
…esianChart to support it (microsoft#15664)

Cherry-pick of microsoft#15296.
@ecraig12345 ecraig12345 removed the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raghurk Raghurk Raghurk approved these changes

Assignees

@miroslavstastny miroslavstastny

Labels
Package: charting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shivasai09 @msft-github-bot @Raghurk @ecraig12345 @khmakoto @miroslavstastny