Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charting: Area chart unit test cases #15520

Merged
merged 3 commits into from
Oct 16, 2020
Merged

Charting: Area chart unit test cases #15520

merged 3 commits into from
Oct 16, 2020

Conversation

jameelakowsar
Copy link
Contributor

Pull request checklist

Description of changes

Added Snapshot and basic unit test cases to area chart.

Focus areas to test

Area chart.

Jameela Kowsar Shaik (Zen3 Infosolutions America Inc) added 3 commits October 15, 2020 10:40
@msft-github-bot msft-github-bot added the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Oct 15, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e281034:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-next-template Configuration
codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
Avatar mount 918 909 5000
BaseButton mount 1000 994 5000
Breadcrumb mount 43976 43911 5000
ButtonNext mount 715 770 5000
Checkbox mount 1741 1769 5000
CheckboxBase mount 1482 1530 5000
ChoiceGroup mount 5402 5537 5000
ComboBox mount 1062 1012 1000
CommandBar mount 8212 8126 1000
ContextualMenu mount 16019 16391 1000
DefaultButton mount 1251 1256 5000
DetailsRow mount 3925 3923 5000
DetailsRowFast mount 3869 3938 5000
DetailsRowNoStyles mount 3745 3804 5000
Dialog mount 1559 1645 1000
DocumentCardTitle mount 1891 1874 1000
Dropdown mount 2853 2857 5000
FocusTrapZone mount 1835 1813 5000
FocusZone mount 2077 1970 5000
IconButton mount 1974 1989 5000
Label mount 353 355 5000
Layer mount 2111 2169 5000
Link mount 501 490 5000
MenuButton mount 1636 1636 5000
MessageBar mount 2218 2160 5000
Nav mount 3586 3559 1000
OverflowSet mount 1532 1519 5000
Panel mount 1580 1583 1000
Persona mount 902 902 1000
Pivot mount 1522 1556 1000
PrimaryButton mount 1426 1385 5000
Rating mount 8501 8432 5000
SearchBox mount 1421 1432 5000
Shimmer mount 2915 2896 5000
Slider mount 1619 1633 5000
SpinButton mount 5443 5442 5000
Spinner mount 448 453 5000
SplitButton mount 3453 3502 5000
Stack mount 567 566 5000
StackWithIntrinsicChildren mount 1649 1701 5000
StackWithTextChildren mount 5257 5206 5000
SwatchColorPicker mount 11362 11212 5000
TagPicker mount 2992 3067 5000
TeachingBubble mount 53337 53674 5000
Text mount 476 486 5000
TextField mount 1576 1594 5000
ThemeProvider mount 1784 1797 5000
ThemeProvider virtual-rerender 671 680 5000
Toggle mount 903 897 5000
button mount 119 114 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.51 0.53 0.96:1 2000 1029
🦄 Button.Fluent 0.13 0.23 0.57:1 5000 659
🔧 Checkbox.Fluent 0.7 0.43 1.63:1 1000 697
🎯 Dialog.Fluent 0.18 0.25 0.72:1 5000 902
🔧 Dropdown.Fluent 3.15 0.52 6.06:1 1000 3152
🔧 Icon.Fluent 0.16 0.07 2.29:1 5000 803
🎯 Image.Fluent 0.1 0.13 0.77:1 5000 511
🔧 Slider.Fluent 1.67 0.41 4.07:1 1000 1670
🔧 Text.Fluent 0.09 0.04 2.25:1 5000 429
🦄 Tooltip.Fluent 0.13 19.51 0.01:1 5000 632

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 176 0 Infinity:1
AlertMinimalPerf.default 370 0 Infinity:1
AnimationMinimalPerf.default 465 0 Infinity:1
AttachmentMinimalPerf.default 188 0 Infinity:1
AttachmentSlotsPerf.default 1309 0 Infinity:1
BoxMinimalPerf.default 434 0 Infinity:1
ButtonMinimalPerf.default 221 0 Infinity:1
ButtonOverridesMissPerf.default 1887 0 Infinity:1
ButtonUseCssPerf.default 954 0 Infinity:1
ButtonUseCssNestingPerf.default 1221 0 Infinity:1
CardMinimalPerf.default 707 0 Infinity:1
CarouselMinimalPerf.default 528 0 Infinity:1
ChatMinimalPerf.default 768 0 Infinity:1
ChatWithPopoverPerf.default 546 0 Infinity:1
CheckboxMinimalPerf.default 3167 0 Infinity:1
DialogMinimalPerf.default 932 0 Infinity:1
DividerMinimalPerf.default 451 0 Infinity:1
DropdownManyItemsPerf.default 858 0 Infinity:1
DropdownMinimalPerf.default 3139 0 Infinity:1
EmbedMinimalPerf.default 2213 0 Infinity:1
FlexMinimalPerf.default 368 0 Infinity:1
FormMinimalPerf.default 522 0 Infinity:1
GridMinimalPerf.default 435 0 Infinity:1
HeaderMinimalPerf.default 447 0 Infinity:1
HeaderSlotsPerf.default 940 0 Infinity:1
InputMinimalPerf.default 1455 0 Infinity:1
ItemLayoutMinimalPerf.default 1486 0 Infinity:1
LabelMinimalPerf.default 518 0 Infinity:1
LayoutMinimalPerf.default 505 0 Infinity:1
ListCommonPerf.default 777 0 Infinity:1
ListMinimalPerf.default 572 0 Infinity:1
ListNestedPerf.default 704 0 Infinity:1
ListWith60ListItems.default 1056 0 Infinity:1
LoaderMinimalPerf.default 820 0 Infinity:1
MenuMinimalPerf.default 1017 0 Infinity:1
PortalMinimalPerf.default 188 0 Infinity:1
ProviderMinimalPerf.default 1108 0 Infinity:1
RadioGroupMinimalPerf.default 525 0 Infinity:1
ReactionMinimalPerf.default 467 0 Infinity:1
RefMinimalPerf.default 282 0 Infinity:1
SegmentMinimalPerf.default 456 0 Infinity:1
SkeletonMinimalPerf.default 497 0 Infinity:1
SliderMinimalPerf.default 1668 0 Infinity:1
SplitButtonMinimalPerf.default 4255 0 Infinity:1
StatusMinimalPerf.default 861 0 Infinity:1
IconMinimalPerf.default 824 0 Infinity:1
TableManyItemsPerf.default 2608 0 Infinity:1
TableMinimalPerf.default 496 0 Infinity:1
TextMinimalPerf.default 456 0 Infinity:1
CustomToolbarPrototype.default 4163 0 Infinity:1
ToolbarMinimalPerf.default 1080 0 Infinity:1
TooltipMinimalPerf.default 904 0 Infinity:1
TreeMinimalPerf.default 1025 0 Infinity:1
TreeWith60ListItems.default 222 0 Infinity:1
VideoMinimalPerf.default 723 0 Infinity:1
Avatar.Fluent 1029 0 Infinity:1
Button.Fluent 659 0 Infinity:1
Checkbox.Fluent 697 0 Infinity:1
Dropdown.Fluent 3152 0 Infinity:1
Icon.Fluent 803 0 Infinity:1
Image.Fluent 511 0 Infinity:1
Slider.Fluent 1670 0 Infinity:1
Tooltip.Fluent 632 0 Infinity:1
ProviderMergeThemesPerf.default 2178 1 2178:1
MenuButtonMinimalPerf.default 1800 1 1800:1
Dialog.Fluent 902 1 902:1
PopupMinimalPerf.default 784 1 784:1
ButtonSlotsPerf.default 692 1 692:1
TextAreaMinimalPerf.default 598 1 598:1
AvatarMinimalPerf.default 568 1 568:1
ChatDuplicateMessagesPerf.default 485 1 485:1
ImageMinimalPerf.default 467 1 467:1
Text.Fluent 429 1 429:1

@size-auditor
Copy link

size-auditor bot commented Oct 15, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 8828fdca589a3b4f9119798fb806163e29961a41 (build)

@khmakoto khmakoto mentioned this pull request Oct 15, 2020
Closed
40 tasks
@jameelakowsar jameelakowsar marked this pull request as ready for review October 16, 2020 03:58
@Raghurk Raghurk merged commit 252baba into microsoft:7.0 Oct 16, 2020
@msft-github-bot
Copy link
Contributor

🎉@uifabric/charting@v4.7.4 has been released which incorporates this pull request.:tada:

Handy links:

@khmakoto khmakoto mentioned this pull request Oct 26, 2020
Merged
2 tasks
ecraig12345 pushed a commit that referenced this pull request Oct 26, 2020
@khmakoto
Charting: Adding tests for AreaChart (#15702)
0fe2bfa 
Cherry-pick of #15520.
SethDonohue pushed a commit to SethDonohue/fluentui that referenced this pull request Nov 2, 2020
@khmakoto
Charting: Adding tests for AreaChart (microsoft#15702)
c8fc918 
Cherry-pick of microsoft#15520.
@ecraig12345 ecraig12345 removed the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raghurk Raghurk Raghurk approved these changes

Assignees

@tomi-msft tomi-msft

Labels
Package: charting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jameelakowsar @msft-github-bot @Raghurk @ecraig12345 @tomi-msft