Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command bar role #15614

Merged
merged 2 commits into from
Oct 20, 2020
Merged

Command bar role #15614

merged 2 commits into from
Oct 20, 2020

Conversation

khmakoto
Copy link
Member

@khmakoto khmakoto commented Oct 20, 2020 •
edited
Loading

Pull request checklist

Description of changes

Cherry-pick of #15511.

Original PR description:

Fix having incorrectly set role="group" in between menubar and menuitem.

Focus areas to test

(optional)

@khmakoto khmakoto requested a review from xugao October 20, 2020 17:35
@khmakoto khmakoto mentioned this pull request Oct 20, 2020
Closed
40 tasks
@khmakoto
Copy link
Member Author

@msft-github-bot merge in 1 minute.

@msft-github-bot
Copy link
Contributor

Hello @khmakoto!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Tue, 20 Oct 2020 17:44:24 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7cfd849:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 929 935 5000
BaseButtonCompat mount 1004 981 5000
Breadcrumb mount 168891 167121 5000
Checkbox mount 1633 1650 5000
CheckboxBase mount 1380 1369 5000
ChoiceGroup mount 5248 5159 5000
ComboBox mount 1009 1021 1000
CommandBar mount 22716 22759 1000
ContextualMenu mount 6575 6541 1000
DefaultButtonCompat mount 1203 1255 5000
DetailsRow mount 3962 3871 5000
DetailsRowFast mount 3961 3992 5000
DetailsRowNoStyles mount 3720 3728 5000
Dialog mount 1605 1658 1000
DocumentCardTitle mount 1901 1881 1000
Dropdown mount 3711 3712 5000
FocusTrapZone mount 1904 1913 5000
FocusZone mount 1908 1875 5000
IconButtonCompat mount 1943 1981 5000
Label mount 349 353 5000
Layer mount 1985 1978 5000
Link mount 481 488 5000
MenuButtonCompat mount 1611 1649 5000
MessageBar mount 2153 2144 5000
Nav mount 3612 3490 1000
OverflowSet mount 1109 1096 5000
Panel mount 1554 1535 1000
Persona mount 931 927 1000
Pivot mount 1518 1522 1000
PrimaryButtonCompat mount 1377 1393 5000
Rating mount 8107 8325 5000
SearchBox mount 1432 1455 5000
Shimmer mount 2807 2825 5000
Slider mount 2069 1998 5000
SpinButton mount 5488 5430 5000
Spinner mount 467 454 5000
SplitButtonCompat mount 3473 3477 5000
Stack mount 551 549 5000
StackWithIntrinsicChildren mount 1685 1657 5000
StackWithTextChildren mount 5176 5213 5000
SwatchColorPicker mount 11014 10989 5000
TagPicker mount 2889 2961 5000
TeachingBubble mount 12293 12354 5000
Text mount 478 474 5000
TextField mount 1487 1507 5000
ThemeProvider mount 2089 2077 5000
ThemeProvider virtual-rerender 680 687 5000
Toggle mount 855 882 5000
button mount 609 591 5000
buttonNative mount 109 117 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.52 0.55 0.95:1 2000 1035
🦄 Button.Fluent 0.13 0.26 0.5:1 5000 672
🔧 Checkbox.Fluent 0.72 0.38 1.89:1 1000 716
🎯 Dialog.Fluent 0.18 0.25 0.72:1 5000 918
🔧 Dropdown.Fluent 3.17 0.46 6.89:1 1000 3173
🔧 Icon.Fluent 0.16 0.07 2.29:1 5000 804
🎯 Image.Fluent 0.1 0.14 0.71:1 5000 476
🔧 Slider.Fluent 1.76 0.49 3.59:1 1000 1757
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 421
🦄 Tooltip.Fluent 0.13 0.96 0.14:1 5000 642

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 234 207 1.13:1
AccordionMinimalPerf.default 203 183 1.11:1
AttachmentMinimalPerf.default 210 190 1.11:1
AnimationMinimalPerf.default 497 450 1.1:1
RefMinimalPerf.default 271 246 1.1:1
DividerMinimalPerf.default 471 439 1.07:1
PortalMinimalPerf.default 186 175 1.06:1
ReactionMinimalPerf.default 494 468 1.06:1
VideoMinimalPerf.default 743 701 1.06:1
CarouselMinimalPerf.default 555 528 1.05:1
ChatDuplicateMessagesPerf.default 486 465 1.05:1
ChatMinimalPerf.default 732 700 1.05:1
FormMinimalPerf.default 533 508 1.05:1
ListMinimalPerf.default 591 561 1.05:1
SegmentMinimalPerf.default 437 416 1.05:1
IconMinimalPerf.default 797 758 1.05:1
TextAreaMinimalPerf.default 605 577 1.05:1
Checkbox.Fluent 716 685 1.05:1
ButtonSlotsPerf.default 691 667 1.04:1
ButtonUseCssNestingPerf.default 1240 1193 1.04:1
GridMinimalPerf.default 452 433 1.04:1
ListCommonPerf.default 759 731 1.04:1
PopupMinimalPerf.default 798 764 1.04:1
Tooltip.Fluent 642 615 1.04:1
AlertMinimalPerf.default 360 351 1.03:1
DropdownManyItemsPerf.default 878 853 1.03:1
LabelMinimalPerf.default 515 498 1.03:1
LayoutMinimalPerf.default 481 469 1.03:1
SkeletonMinimalPerf.default 505 491 1.03:1
StatusMinimalPerf.default 850 829 1.03:1
Button.Fluent 672 653 1.03:1
Dialog.Fluent 918 890 1.03:1
Image.Fluent 476 460 1.03:1
BoxMinimalPerf.default 441 431 1.02:1
ButtonOverridesMissPerf.default 1919 1879 1.02:1
ButtonUseCssPerf.default 946 925 1.02:1
ChatWithPopoverPerf.default 549 538 1.02:1
FlexMinimalPerf.default 348 340 1.02:1
HeaderSlotsPerf.default 948 932 1.02:1
InputMinimalPerf.default 1454 1427 1.02:1
LoaderMinimalPerf.default 821 808 1.02:1
SplitButtonMinimalPerf.default 4289 4207 1.02:1
TableMinimalPerf.default 500 492 1.02:1
AttachmentSlotsPerf.default 1280 1264 1.01:1
CardMinimalPerf.default 665 658 1.01:1
CheckboxMinimalPerf.default 3131 3106 1.01:1
DialogMinimalPerf.default 896 888 1.01:1
DropdownMinimalPerf.default 3172 3152 1.01:1
EmbedMinimalPerf.default 2206 2177 1.01:1
ItemLayoutMinimalPerf.default 1490 1469 1.01:1
MenuMinimalPerf.default 1015 1007 1.01:1
MenuButtonMinimalPerf.default 1819 1798 1.01:1
ProviderMergeThemesPerf.default 2181 2164 1.01:1
TableManyItemsPerf.default 2526 2489 1.01:1
TreeMinimalPerf.default 1042 1034 1.01:1
AvatarMinimalPerf.default 532 534 1:1
HeaderMinimalPerf.default 447 447 1:1
ImageMinimalPerf.default 468 467 1:1
ListWith60ListItems.default 1039 1040 1:1
ProviderMinimalPerf.default 1121 1125 1:1
RadioGroupMinimalPerf.default 518 517 1:1
CustomToolbarPrototype.default 4260 4250 1:1
Avatar.Fluent 1035 1032 1:1
Dropdown.Fluent 3173 3170 1:1
SliderMinimalPerf.default 1712 1724 0.99:1
TooltipMinimalPerf.default 922 929 0.99:1
Icon.Fluent 804 810 0.99:1
Slider.Fluent 1757 1767 0.99:1
ListNestedPerf.default 648 663 0.98:1
ToolbarMinimalPerf.default 1079 1098 0.98:1
TextMinimalPerf.default 422 434 0.97:1
Text.Fluent 421 441 0.95:1
TreeWith60ListItems.default 232 250 0.93:1

@size-auditor
Copy link

size-auditor bot commented Oct 20, 2020

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react fluentui-react-CommandBar 185.903 kB 185.927 kB ExceedsBaseline     24 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: 1f144cef92621ad25f625f587d1ea1b6831d6e64 (build)

@msft-github-bot msft-github-bot merged commit 07e4870 into microsoft:master Oct 20, 2020
@khmakoto khmakoto deleted the commandBarRole branch October 20, 2020 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joschect joschect joschect approved these changes

@xugao xugao Awaiting requested review from xugao

@micahgodbolt micahgodbolt Awaiting requested review from micahgodbolt

Assignees

@tomi-msft tomi-msft

Labels
AutoMerge Component: CommandBar
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@khmakoto @msft-github-bot @joschect @tomi-msft