Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update react-compose beachball config #15695

Merged
merged 2 commits into from
Oct 26, 2020
Merged

Update react-compose beachball config #15695

merged 2 commits into from
Oct 26, 2020

Conversation

xugao
Copy link
Contributor

@xugao xugao commented Oct 26, 2020 •
edited
Loading

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Update react-compose beachball config to use root-level beachball config (for beta packages)

Focus areas to test

(optional)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ea9e8af:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 859 865 5000
BaseButtonCompat mount 924 922 5000
Breadcrumb mount 156027 155606 5000
Checkbox mount 1521 1578 5000
CheckboxBase mount 1337 1380 5000
ChoiceGroup mount 4870 4937 5000
ComboBox mount 985 961 1000
CommandBar mount 21551 21407 1000
ContextualMenu mount 6135 6032 1000
DefaultButtonCompat mount 1157 1186 5000
DetailsRow mount 3720 3695 5000
DetailsRowFast mount 3674 3690 5000
DetailsRowNoStyles mount 3495 3454 5000
Dialog mount 1547 1549 1000
DocumentCardTitle mount 1765 1767 1000
Dropdown mount 3472 3471 5000
FocusTrapZone mount 1823 1827 5000
FocusZone mount 1822 1782 5000
IconButtonCompat mount 1854 1857 5000
Label mount 339 345 5000
Layer mount 1867 1840 5000
Link mount 467 476 5000
MenuButtonCompat mount 1503 1541 5000
MessageBar mount 2017 2079 5000
Nav mount 3361 3335 1000
OverflowSet mount 1038 1069 5000
Panel mount 1454 1447 1000
Persona mount 867 871 1000
Pivot mount 1457 1393 1000
PrimaryButtonCompat mount 1329 1331 5000
Rating mount 7934 7846 5000
SearchBox mount 1396 1405 5000
Shimmer mount 2601 2670 5000
Slider mount 1989 1926 5000
SpinButton mount 5300 5103 5000
Spinner mount 434 417 5000
SplitButtonCompat mount 3168 3305 5000
Stack mount 537 516 5000
StackWithIntrinsicChildren mount 1671 1612 5000
StackWithTextChildren mount 4957 4948 5000
SwatchColorPicker mount 10472 10463 5000
TagPicker mount 2851 2868 5000
TeachingBubble mount 11714 11619 5000
Text mount 452 437 5000
TextField mount 1428 1417 5000
ThemeProvider mount 1958 1977 5000
ThemeProvider virtual-rerender 641 636 5000
Toggle mount 819 799 5000
button mount 561 563 5000
buttonNative mount 112 102 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.47 0.52 0.9:1 2000 937
🦄 Button.Fluent 0.13 0.26 0.5:1 5000 629
🔧 Checkbox.Fluent 0.66 0.37 1.78:1 1000 657
🎯 Dialog.Fluent 0.17 0.23 0.74:1 5000 864
🔧 Dropdown.Fluent 2.92 0.43 6.79:1 1000 2916
🔧 Icon.Fluent 0.16 0.06 2.67:1 5000 810
🦄 Image.Fluent 0.09 0.13 0.69:1 5000 442
🔧 Slider.Fluent 1.63 0.45 3.62:1 1000 1633
🔧 Text.Fluent 0.08 0.04 2:1 5000 414
🦄 Tooltip.Fluent 0.12 0.92 0.13:1 5000 583

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
Text.Fluent 414 377 1.1:1
SegmentMinimalPerf.default 434 398 1.09:1
ButtonMinimalPerf.default 211 196 1.08:1
ImageMinimalPerf.default 462 429 1.08:1
ButtonSlotsPerf.default 674 628 1.07:1
CarouselMinimalPerf.default 496 470 1.06:1
PortalMinimalPerf.default 167 158 1.06:1
Icon.Fluent 810 767 1.06:1
AttachmentMinimalPerf.default 181 172 1.05:1
DropdownManyItemsPerf.default 813 777 1.05:1
ListMinimalPerf.default 546 522 1.05:1
TreeWith60ListItems.default 231 220 1.05:1
VideoMinimalPerf.default 712 678 1.05:1
AnimationMinimalPerf.default 435 420 1.04:1
GridMinimalPerf.default 406 389 1.04:1
HeaderMinimalPerf.default 433 418 1.04:1
ListNestedPerf.default 634 611 1.04:1
MenuMinimalPerf.default 944 911 1.04:1
TreeMinimalPerf.default 1018 977 1.04:1
ChatWithPopoverPerf.default 501 485 1.03:1
FlexMinimalPerf.default 324 316 1.03:1
ItemLayoutMinimalPerf.default 1426 1382 1.03:1
ListWith60ListItems.default 994 963 1.03:1
PopupMinimalPerf.default 757 737 1.03:1
ProviderMinimalPerf.default 1073 1039 1.03:1
Avatar.Fluent 937 914 1.03:1
Button.Fluent 629 610 1.03:1
Checkbox.Fluent 657 635 1.03:1
Dialog.Fluent 864 837 1.03:1
ButtonUseCssPerf.default 906 892 1.02:1
DividerMinimalPerf.default 421 412 1.02:1
DropdownMinimalPerf.default 3024 2973 1.02:1
HeaderSlotsPerf.default 886 867 1.02:1
ListCommonPerf.default 728 713 1.02:1
ProviderMergeThemesPerf.default 2046 2011 1.02:1
SliderMinimalPerf.default 1592 1567 1.02:1
TableManyItemsPerf.default 2430 2387 1.02:1
TableMinimalPerf.default 465 454 1.02:1
Tooltip.Fluent 583 574 1.02:1
AlertMinimalPerf.default 347 345 1.01:1
AvatarMinimalPerf.default 522 516 1.01:1
ButtonOverridesMissPerf.default 1782 1757 1.01:1
ChatMinimalPerf.default 672 663 1.01:1
CheckboxMinimalPerf.default 2958 2920 1.01:1
LoaderMinimalPerf.default 785 777 1.01:1
MenuButtonMinimalPerf.default 1658 1647 1.01:1
ReactionMinimalPerf.default 454 450 1.01:1
SplitButtonMinimalPerf.default 3985 3953 1.01:1
IconMinimalPerf.default 741 737 1.01:1
TextMinimalPerf.default 416 411 1.01:1
CustomToolbarPrototype.default 3902 3866 1.01:1
ToolbarMinimalPerf.default 997 991 1.01:1
TooltipMinimalPerf.default 839 833 1.01:1
BoxMinimalPerf.default 404 406 1:1
DialogMinimalPerf.default 835 839 1:1
InputMinimalPerf.default 1337 1331 1:1
LabelMinimalPerf.default 481 480 1:1
StatusMinimalPerf.default 796 800 1:1
AttachmentSlotsPerf.default 1175 1183 0.99:1
EmbedMinimalPerf.default 2037 2063 0.99:1
LayoutMinimalPerf.default 448 452 0.99:1
RefMinimalPerf.default 241 244 0.99:1
Dropdown.Fluent 2916 2943 0.99:1
Image.Fluent 442 446 0.99:1
Slider.Fluent 1633 1646 0.99:1
ButtonUseCssNestingPerf.default 1114 1144 0.97:1
RadioGroupMinimalPerf.default 471 486 0.97:1
TextAreaMinimalPerf.default 536 551 0.97:1
CardMinimalPerf.default 618 641 0.96:1
ChatDuplicateMessagesPerf.default 426 443 0.96:1
AccordionMinimalPerf.default 174 183 0.95:1
SkeletonMinimalPerf.default 468 494 0.95:1
FormMinimalPerf.default 470 519 0.91:1

@size-auditor
Copy link

size-auditor bot commented Oct 26, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 0eac5198b9c5a921a0437de96305c4b28cc6048c (build)

@xugao xugao merged commit 1370675 into microsoft:master Oct 26, 2020
SethDonohue pushed a commit to SethDonohue/fluentui that referenced this pull request Nov 2, 2020
@xugao
Update react-compose beachball config (microsoft#15695)
d0cf2c6 
* update react-compose beachball config

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecraig12345 ecraig12345 ecraig12345 approved these changes

@dzearing dzearing Awaiting requested review from dzearing

Assignees

@tomi-msft tomi-msft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xugao @msft-github-bot @ecraig12345 @tomi-msft