Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charting: Updating VerticalBarChart tests #15703

Merged
merged 2 commits into from
Oct 26, 2020
Merged

Charting: Updating VerticalBarChart tests #15703

merged 2 commits into from
Oct 26, 2020

Conversation

khmakoto
Copy link
Member

Pull request checklist

Description of changes

Cherry-pick of #15523.

Original PR description:

Updated snapshot and basic unit test cases of the vertical bar chart.

Focus areas to test

Vertical bar chart

@khmakoto khmakoto mentioned this pull request Oct 26, 2020
Closed
40 tasks
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8b103f6:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 915 965 5000
BaseButtonCompat mount 1012 1037 5000
Breadcrumb mount 164297 162903 5000
Checkbox mount 1667 1651 5000
CheckboxBase mount 1391 1421 5000
ChoiceGroup mount 5119 5343 5000
ComboBox mount 1115 1014 1000
CommandBar mount 23129 23026 1000
ContextualMenu mount 6575 6494 1000
DefaultButtonCompat mount 1297 1305 5000
DetailsRow mount 3944 4107 5000
DetailsRowFast mount 4135 4001 5000
DetailsRowNoStyles mount 3695 3782 5000
Dialog mount 1698 1638 1000
DocumentCardTitle mount 1934 1937 1000
Dropdown mount 3811 3991 5000
FocusTrapZone mount 1934 1955 5000
FocusZone mount 1951 1954 5000
IconButtonCompat mount 2046 1976 5000
Label mount 394 402 5000
Layer mount 2016 2051 5000
Link mount 511 522 5000
MenuButtonCompat mount 1655 1659 5000
MessageBar mount 2147 2260 5000
Nav mount 3522 3633 1000
OverflowSet mount 1143 1129 5000
Panel mount 1583 1636 1000
Persona mount 919 946 1000
Pivot mount 1536 1559 1000
PrimaryButtonCompat mount 1393 1409 5000
Rating mount 8271 8154 5000
SearchBox mount 1444 1415 5000
Shimmer mount 2858 2763 5000
Slider mount 2108 2084 5000
SpinButton mount 5382 5561 5000
Spinner mount 441 438 5000
SplitButtonCompat mount 3591 3526 5000
Stack mount 550 568 5000
StackWithIntrinsicChildren mount 1739 1716 5000
StackWithTextChildren mount 5314 5234 5000
SwatchColorPicker mount 11120 11340 5000
TagPicker mount 2986 2903 5000
TeachingBubble mount 12240 12510 5000
Text mount 500 490 5000
TextField mount 1527 1528 5000
ThemeProvider mount 2179 2246 5000
ThemeProvider virtual-rerender 714 702 5000
Toggle mount 924 911 5000
button mount 609 621 5000
buttonNative mount 124 117 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.54 0.58 0.93:1 2000 1071
🦄 Button.Fluent 0.14 0.28 0.5:1 5000 709
🔧 Checkbox.Fluent 0.74 0.39 1.9:1 1000 738
🦄 Dialog.Fluent 0.18 0.26 0.69:1 5000 912
🔧 Dropdown.Fluent 3.38 0.48 7.04:1 1000 3376
🔧 Icon.Fluent 0.17 0.07 2.43:1 5000 850
🦄 Image.Fluent 0.09 0.15 0.6:1 5000 465
🔧 Slider.Fluent 1.83 0.52 3.52:1 1000 1826
🔧 Text.Fluent 0.09 0.03 3:1 5000 436
🦄 Tooltip.Fluent 0.13 1 0.13:1 5000 646

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
PortalMinimalPerf.default 207 182 1.14:1
TreeWith60ListItems.default 269 238 1.13:1
ButtonMinimalPerf.default 232 209 1.11:1
RefMinimalPerf.default 281 253 1.11:1
AlertMinimalPerf.default 408 373 1.09:1
ImageMinimalPerf.default 504 477 1.06:1
ChatMinimalPerf.default 740 707 1.05:1
HeaderMinimalPerf.default 459 436 1.05:1
ItemLayoutMinimalPerf.default 1564 1486 1.05:1
SegmentMinimalPerf.default 447 425 1.05:1
AttachmentSlotsPerf.default 1350 1301 1.04:1
ButtonUseCssPerf.default 996 957 1.04:1
ChatWithPopoverPerf.default 558 539 1.04:1
FlexMinimalPerf.default 364 349 1.04:1
LoaderMinimalPerf.default 854 822 1.04:1
PopupMinimalPerf.default 824 791 1.04:1
RadioGroupMinimalPerf.default 549 528 1.04:1
VideoMinimalPerf.default 759 728 1.04:1
FormMinimalPerf.default 505 490 1.03:1
SkeletonMinimalPerf.default 527 514 1.03:1
StatusMinimalPerf.default 892 862 1.03:1
ToolbarMinimalPerf.default 1145 1109 1.03:1
Slider.Fluent 1826 1774 1.03:1
Text.Fluent 436 423 1.03:1
ButtonSlotsPerf.default 697 682 1.02:1
CarouselMinimalPerf.default 540 528 1.02:1
DividerMinimalPerf.default 456 447 1.02:1
DropdownMinimalPerf.default 3263 3212 1.02:1
ListCommonPerf.default 772 759 1.02:1
SliderMinimalPerf.default 1796 1761 1.02:1
TextMinimalPerf.default 446 438 1.02:1
CustomToolbarPrototype.default 4508 4427 1.02:1
Button.Fluent 709 694 1.02:1
Dropdown.Fluent 3376 3304 1.02:1
BoxMinimalPerf.default 459 455 1.01:1
CardMinimalPerf.default 691 685 1.01:1
GridMinimalPerf.default 408 404 1.01:1
HeaderSlotsPerf.default 955 942 1.01:1
InputMinimalPerf.default 1499 1481 1.01:1
ListWith60ListItems.default 1063 1055 1.01:1
MenuButtonMinimalPerf.default 1857 1836 1.01:1
SplitButtonMinimalPerf.default 4370 4326 1.01:1
TextAreaMinimalPerf.default 635 631 1.01:1
TooltipMinimalPerf.default 967 960 1.01:1
Checkbox.Fluent 738 729 1.01:1
Icon.Fluent 850 842 1.01:1
AttachmentMinimalPerf.default 200 201 1:1
ButtonUseCssNestingPerf.default 1252 1249 1:1
CheckboxMinimalPerf.default 3204 3203 1:1
DialogMinimalPerf.default 909 905 1:1
DropdownManyItemsPerf.default 899 902 1:1
EmbedMinimalPerf.default 2245 2256 1:1
ListNestedPerf.default 667 669 1:1
ProviderMergeThemesPerf.default 2308 2314 1:1
TreeMinimalPerf.default 1081 1082 1:1
Avatar.Fluent 1071 1071 1:1
Tooltip.Fluent 646 646 1:1
LayoutMinimalPerf.default 496 502 0.99:1
MenuMinimalPerf.default 1024 1039 0.99:1
ProviderMinimalPerf.default 1161 1174 0.99:1
ReactionMinimalPerf.default 489 492 0.99:1
TableManyItemsPerf.default 2621 2653 0.99:1
TableMinimalPerf.default 502 509 0.99:1
Dialog.Fluent 912 919 0.99:1
AnimationMinimalPerf.default 480 488 0.98:1
ButtonOverridesMissPerf.default 1975 2010 0.98:1
LabelMinimalPerf.default 490 502 0.98:1
ListMinimalPerf.default 574 588 0.98:1
Image.Fluent 465 476 0.98:1
AvatarMinimalPerf.default 569 585 0.97:1
ChatDuplicateMessagesPerf.default 483 502 0.96:1
IconMinimalPerf.default 752 802 0.94:1
AccordionMinimalPerf.default 183 199 0.92:1

@size-auditor
Copy link

size-auditor bot commented Oct 26, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 0b370e43432789ee9b170f60a8276b594493ca7a (build)

@ecraig12345 ecraig12345 merged commit b2a4c18 into microsoft:master Oct 26, 2020
@khmakoto khmakoto deleted the verticalBarChartTestsUpdated branch October 26, 2020 23:47
SethDonohue pushed a commit to SethDonohue/fluentui that referenced this pull request Nov 2, 2020
@khmakoto
Charting: Updating VerticalBarChart tests (microsoft#15703)
caa7cb1 
Cherry-pick of microsoft#15523.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecraig12345 ecraig12345 ecraig12345 approved these changes

@Raghurk Raghurk Awaiting requested review from Raghurk

Assignees

@tomi-msft tomi-msft

Labels
Package: charting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@khmakoto @msft-github-bot @ecraig12345 @tomi-msft