Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

public-docsite: fix dev webpack output folder path #15723

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

xugao
Copy link
Contributor

@xugao xugao commented Oct 27, 2020

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

fix public-docsite dev webpack output folder path

Focus areas to test

(optional)

@ecraig12345 ecraig12345 reopened this Oct 27, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4e66f4c:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@xugao xugao merged commit 9f060c1 into microsoft:master Oct 27, 2020
@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 860 826 5000
BaseButtonCompat mount 903 940 5000
Breadcrumb mount 43141 43269 5000
Checkbox mount 1587 1505 5000
CheckboxBase mount 1290 1280 5000
ChoiceGroup mount 4892 4740 5000
ComboBox mount 1013 999 1000
CommandBar mount 10313 10175 1000
ContextualMenu mount 6224 6191 1000
DefaultButtonCompat mount 1110 1135 5000
DetailsRow mount 3616 3612 5000
DetailsRowFast mount 3582 3704 5000
DetailsRowNoStyles mount 3429 3596 5000
Dialog mount 1532 1532 1000
DocumentCardTitle mount 1834 1819 1000
Dropdown mount 3446 3412 5000
FocusTrapZone mount 1887 1810 5000
FocusZone mount 1806 1802 5000
IconButtonCompat mount 1725 1777 5000
Label mount 333 347 5000
Layer mount 1846 1815 5000
Link mount 484 480 5000
MenuButtonCompat mount 1463 1503 5000
MessageBar mount 2026 2037 5000
Nav mount 3259 3263 1000
OverflowSet mount 1076 1080 5000
Panel mount 1465 1397 1000
Persona mount 869 846 1000
Pivot mount 1399 1430 1000
PrimaryButtonCompat mount 1270 1287 5000
Rating mount 7498 7526 5000
SearchBox mount 1324 1291 5000
Shimmer mount 2552 2603 5000
Slider mount 1894 1884 5000
SpinButton mount 5042 5106 5000
Spinner mount 433 423 5000
SplitButtonCompat mount 3160 3202 5000
Stack mount 531 493 5000
StackWithIntrinsicChildren mount 1522 1498 5000
StackWithTextChildren mount 4609 4683 5000
SwatchColorPicker mount 10315 10346 5000
TagPicker mount 2756 2756 5000
TeachingBubble mount 11499 11644 5000
Text mount 441 446 5000
TextField mount 1360 1391 5000
ThemeProvider mount 2029 2016 5000
ThemeProvider virtual-rerender 649 633 5000
Toggle mount 790 839 5000
button mount 561 570 5000
buttonNative mount 112 121 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.45 0.5 0.9:1 2000 906
🦄 Button.Fluent 0.12 0.23 0.52:1 5000 610
🔧 Checkbox.Fluent 0.66 0.35 1.89:1 1000 662
🦄 Dialog.Fluent 0.16 0.24 0.67:1 5000 813
🔧 Dropdown.Fluent 3.03 0.43 7.05:1 1000 3034
🔧 Icon.Fluent 0.15 0.06 2.5:1 5000 766
🦄 Image.Fluent 0.08 0.12 0.67:1 5000 412
🔧 Slider.Fluent 1.59 0.44 3.61:1 1000 1592
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 388
🦄 Tooltip.Fluent 0.12 0.91 0.13:1 5000 579

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
FormMinimalPerf.default 474 413 1.15:1
SkeletonMinimalPerf.default 484 430 1.13:1
ReactionMinimalPerf.default 456 408 1.12:1
TreeWith60ListItems.default 241 220 1.1:1
RadioGroupMinimalPerf.default 476 441 1.08:1
ButtonSlotsPerf.default 623 581 1.07:1
ChatWithPopoverPerf.default 513 480 1.07:1
RefMinimalPerf.default 269 252 1.07:1
BoxMinimalPerf.default 414 391 1.06:1
DropdownManyItemsPerf.default 784 741 1.06:1
PopupMinimalPerf.default 751 706 1.06:1
TextMinimalPerf.default 391 374 1.05:1
Image.Fluent 412 391 1.05:1
GridMinimalPerf.default 374 361 1.04:1
HeaderSlotsPerf.default 810 779 1.04:1
ListMinimalPerf.default 520 500 1.04:1
MenuButtonMinimalPerf.default 1647 1580 1.04:1
ToolbarMinimalPerf.default 1003 967 1.04:1
Icon.Fluent 766 736 1.04:1
CarouselMinimalPerf.default 470 456 1.03:1
ChatMinimalPerf.default 649 629 1.03:1
DividerMinimalPerf.default 404 394 1.03:1
ProviderMinimalPerf.default 1071 1035 1.03:1
IconMinimalPerf.default 715 695 1.03:1
Button.Fluent 610 592 1.03:1
Text.Fluent 388 378 1.03:1
AlertMinimalPerf.default 315 309 1.02:1
AnimationMinimalPerf.default 443 436 1.02:1
AvatarMinimalPerf.default 499 489 1.02:1
EmbedMinimalPerf.default 2012 1963 1.02:1
ProviderMergeThemesPerf.default 2161 2122 1.02:1
ButtonOverridesMissPerf.default 1739 1726 1.01:1
ButtonUseCssPerf.default 845 835 1.01:1
ChatDuplicateMessagesPerf.default 437 434 1.01:1
CheckboxMinimalPerf.default 2979 2937 1.01:1
DropdownMinimalPerf.default 3050 3010 1.01:1
HeaderMinimalPerf.default 390 385 1.01:1
ItemLayoutMinimalPerf.default 1296 1287 1.01:1
VideoMinimalPerf.default 655 650 1.01:1
Dropdown.Fluent 3034 3007 1.01:1
AttachmentSlotsPerf.default 1159 1163 1:1
ButtonUseCssNestingPerf.default 1146 1141 1:1
LabelMinimalPerf.default 436 436 1:1
ListNestedPerf.default 597 600 1:1
SplitButtonMinimalPerf.default 3846 3851 1:1
CustomToolbarPrototype.default 3970 3970 1:1
TooltipMinimalPerf.default 845 842 1:1
Avatar.Fluent 906 908 1:1
DialogMinimalPerf.default 819 824 0.99:1
ListCommonPerf.default 664 673 0.99:1
ListWith60ListItems.default 954 960 0.99:1
TextAreaMinimalPerf.default 502 507 0.99:1
TreeMinimalPerf.default 907 916 0.99:1
Checkbox.Fluent 662 672 0.99:1
Slider.Fluent 1592 1605 0.99:1
Tooltip.Fluent 579 583 0.99:1
LoaderMinimalPerf.default 747 760 0.98:1
MenuMinimalPerf.default 886 906 0.98:1
TableManyItemsPerf.default 2199 2250 0.98:1
Dialog.Fluent 813 833 0.98:1
FlexMinimalPerf.default 321 331 0.97:1
SegmentMinimalPerf.default 385 396 0.97:1
SliderMinimalPerf.default 1592 1649 0.97:1
StatusMinimalPerf.default 729 749 0.97:1
CardMinimalPerf.default 575 596 0.96:1
InputMinimalPerf.default 1315 1374 0.96:1
TableMinimalPerf.default 431 451 0.96:1
ImageMinimalPerf.default 400 423 0.95:1
PortalMinimalPerf.default 175 185 0.95:1
AccordionMinimalPerf.default 159 169 0.94:1
LayoutMinimalPerf.default 416 449 0.93:1
AttachmentMinimalPerf.default 165 181 0.91:1
ButtonMinimalPerf.default 175 192 0.91:1

@size-auditor
Copy link

size-auditor bot commented Oct 27, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: e431fceb5cf5acc112d1033fb2e258a002dac8dc (build)

SethDonohue pushed a commit to SethDonohue/fluentui that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants