(web-components) update type ramp #16927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bf26a79:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 42724eecf6ecee9ddc6694f535ece31d5278f979 (build) |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
|
This most noticeably updates the larger sizes in the ramp, which are not commonly used. The common sizes close to the base change line heights only slightly, so this should be safe to take and not break visuals. |
|
@bheston I'd love to get this into the feature branch - the implementation for the system and the tokens are different there, so I don't think this will 1:1 work. Can you open a new PR against |
added 2 commits
May 18, 2021 11:45
bheston
requested review from
EisenbergEffect,
nicholasrice and
a team
as code owners
EisenbergEffect
approved these changes
May 18, 2021
chrisdholt
approved these changes
May 18, 2021
|
Thanks @bheston - this is IN! |
chrisdholt
pushed a commit
that referenced
this pull request
Jun 8, 2021
* Updated type ramp to latest values. * Change files * Updated to new design-tokens definition format Co-authored-by: Brian Heston <brheston@microsoft.com>
chrisdholt
pushed a commit
that referenced
this pull request
Jul 2, 2021
* Updated type ramp to latest values. * Change files * Updated to new design-tokens definition format Co-authored-by: Brian Heston <brheston@microsoft.com>
chrisdholt
pushed a commit
that referenced
this pull request
Jul 2, 2021
* Updated type ramp to latest values. * Change files * Updated to new design-tokens definition format Co-authored-by: Brian Heston <brheston@microsoft.com>
PeterDraex
pushed a commit
to PeterDraex/fluentui
that referenced
this pull request
Aug 6, 2021
* Updated type ramp to latest values. * Change files * Updated to new design-tokens definition format Co-authored-by: Brian Heston <brheston@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
The Fluent type ramp has been updated and this brings the web components into alignment.
Focus areas to test
Web component font size and line height, particularly small and large sizes on the ramp. These are not consumed by the base components currently.