fix: removed SVGs and update fill style in accordion #17527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khamudom
requested review from
chrisdholt,
EisenbergEffect and
nicholasrice
as code owners
EisenbergEffect
approved these changes
Mar 23, 2021
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cf2c0b1:
|
chrisdholt
reviewed
Mar 23, 2021
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 6d000dd560441cc0d29e61e10a7b93d25e7a0997 (build) |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
chrisdholt
approved these changes
Mar 23, 2021
| @@ -85,6 +85,7 @@ export const AccordionItemStyles = css` | |||
| grid-column: 4; | |||
| z-index: 2; | |||
| pointer-events: none; | |||
| fill: var(--accent-fill-rest); | |||
There was a problem hiding this comment.
I think this should use accentFillRestBehavior.var
There was a problem hiding this comment.
thanks @nicholasrice . updated
nicholasrice
approved these changes
Mar 23, 2021
chrisdholt
approved these changes
Mar 24, 2021
|
🎉 Handy links: |
joshualamusga1
pushed a commit
to joshualamusga1/fluentui
that referenced
this pull request
Mar 25, 2021
* removed SVGs to use the default * Change files * set the fill color of the icon in style * using accentFillRestBehavior.var on fill
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
May 5, 2021
* removed SVGs to use the default * Change files * set the fill color of the icon in style * using accentFillRestBehavior.var on fill
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
In the example file, I removed the SVGs to use the default expand and collapsed icons and updated the CSS selector to target the icon's fill property to set the color.
Focus areas to test
(optional)