Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to latest Fast Foundation #19569

Merged
merged 30 commits into from
Aug 30, 2021

Conversation

eljefe223
Copy link
Contributor

@eljefe223 eljefe223 commented Aug 30, 2021

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Updates to latest Fast Foundation

Focus areas to test

(optional)

eljefe223 and others added 30 commits September 17, 2020 15:03
Updating my fork with changes
@eljefe223 eljefe223 enabled auto-merge (squash) August 30, 2021 22:49
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9912f92:

Sandbox Source
Fluent UI React Starter Configuration

@size-auditor
Copy link

size-auditor bot commented Aug 30, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 624ebbfd72804f8594572ccb6f0d08e950e32b39 (build)

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-accordion
Accordion (including children components)
55.727 kB
17.563 kB
react-avatar
Avatar
56.558 kB
15.66 kB
react-badge
Badge
24.343 kB
7.165 kB
react-badge
CounterBadge
27.156 kB
7.851 kB
react-badge
PresenseBadge
237 B
177 B
react-button
Button
25.016 kB
8.035 kB
react-button
CompoundButton
30.308 kB
8.911 kB
react-button
MenuButton
26.603 kB
8.543 kB
react-button
ToggleButton
34.613 kB
8.671 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
166.562 kB
48.102 kB
react-components
react-components: FluentProvider & webLightTheme
36.288 kB
11.615 kB
react-divider
Divider
15.889 kB
5.747 kB
react-image
Image
10.642 kB
4.264 kB
react-label
Label
9.397 kB
3.839 kB
react-link
Link
14.715 kB
6.012 kB
react-make-styles
makeStaticStyles (runtime)
7.59 kB
3.321 kB
react-make-styles
makeStyles + mergeClasses (runtime)
22.135 kB
8.356 kB
react-make-styles
makeStyles + mergeClasses (build time)
2.557 kB
1.202 kB
react-menu
Menu (including children components)
105.997 kB
32.718 kB
react-menu
Menu (including selectable components)
108.727 kB
33.263 kB
react-popover
Popover
102.804 kB
31.283 kB
react-portal
Portal
7.78 kB
2.672 kB
react-positioning
usePopper
23.145 kB
7.942 kB
react-provider
FluentProvider
16.286 kB
5.991 kB
react-text
Text - Default
11.798 kB
4.452 kB
react-text
Text - Wrappers
15.414 kB
4.734 kB
react-theme
Teams: all themes
32.941 kB
6.674 kB
react-theme
Teams: Light theme
20.247 kB
5.662 kB
react-tooltip
Tooltip
46.054 kB
15.658 kB
react-utilities
SSRProvider
213 B
170 B
🤖 This report was generated against 624ebbfd72804f8594572ccb6f0d08e950e32b39

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1008 996 5000
BaseButton mount 1011 1034 5000
Breadcrumb mount 2903 2811 1000
ButtonNext mount 469 494 5000
Checkbox mount 1718 1748 5000
CheckboxBase mount 1468 1496 5000
ChoiceGroup mount 5267 5200 5000
ComboBox mount 1059 1077 1000
CommandBar mount 10979 10949 1000
ContextualMenu mount 6779 6849 1000
DefaultButton mount 1322 1242 5000
DetailsRow mount 4109 4173 5000
DetailsRowFast mount 4281 4168 5000
DetailsRowNoStyles mount 3940 3996 5000
Dialog mount 2320 2314 1000
DocumentCardTitle mount 174 163 1000
Dropdown mount 3536 3605 5000
FluentProviderNext mount 7720 7709 5000
FocusTrapZone mount 1926 1876 5000
FocusZone mount 1900 1921 5000
IconButton mount 1975 2000 5000
Label mount 359 371 5000
Layer mount 2004 1956 5000
Link mount 520 543 5000
MakeStyles mount 1903 1954 50000
MenuButton mount 1645 1633 5000
MessageBar mount 2169 2121 5000
Nav mount 3704 3561 1000
OverflowSet mount 1207 1226 5000
Panel mount 2242 2210 1000
Persona mount 907 917 1000
Pivot mount 1540 1563 1000
PrimaryButton mount 1489 1415 5000
Rating mount 8728 8811 5000
SearchBox mount 1490 1485 5000
Shimmer mount 2861 2895 5000
Slider mount 2149 2130 5000
SpinButton mount 5355 5428 5000
Spinner mount 453 457 5000
SplitButton mount 3516 3475 5000
Stack mount 558 561 5000
StackWithIntrinsicChildren mount 1727 1810 5000
StackWithTextChildren mount 5265 5245 5000
SwatchColorPicker mount 11367 11344 5000
Tabs mount 1540 1553 1000
TagPicker mount 2868 2853 5000
TeachingBubble mount 12710 12617 5000
Text mount 452 481 5000
TextField mount 1563 1542 5000
ThemeProvider mount 1268 1279 5000
ThemeProvider virtual-rerender 638 642 5000
Toggle mount 861 875 5000
buttonNative mount 127 118 5000

Perf Analysis (@fluentui/react-northstar)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
AttachmentMinimalPerf.default 184 178 1.03:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AvatarMinimalPerf.default 230 203 1.13:1
ListNestedPerf.default 667 605 1.1:1
ListMinimalPerf.default 616 566 1.09:1
ChatMinimalPerf.default 784 736 1.07:1
PortalMinimalPerf.default 197 184 1.07:1
RadioGroupMinimalPerf.default 539 502 1.07:1
ButtonOverridesMissPerf.default 1974 1868 1.06:1
RefMinimalPerf.default 258 244 1.06:1
VideoMinimalPerf.default 744 703 1.06:1
CardMinimalPerf.default 662 630 1.05:1
DropdownManyItemsPerf.default 802 765 1.05:1
DropdownMinimalPerf.default 3491 3338 1.05:1
GridMinimalPerf.default 392 374 1.05:1
HeaderSlotsPerf.default 904 861 1.05:1
BoxMinimalPerf.default 404 389 1.04:1
ChatDuplicateMessagesPerf.default 353 338 1.04:1
LabelMinimalPerf.default 457 438 1.04:1
LayoutMinimalPerf.default 444 427 1.04:1
PopupMinimalPerf.default 654 626 1.04:1
TreeMinimalPerf.default 911 879 1.04:1
AlertMinimalPerf.default 326 317 1.03:1
ButtonMinimalPerf.default 201 195 1.03:1
DialogMinimalPerf.default 861 836 1.03:1
InputMinimalPerf.default 1403 1359 1.03:1
ItemLayoutMinimalPerf.default 1396 1349 1.03:1
SkeletonMinimalPerf.default 414 400 1.03:1
TableMinimalPerf.default 459 445 1.03:1
TextAreaMinimalPerf.default 596 578 1.03:1
TooltipMinimalPerf.default 1176 1147 1.03:1
AnimationMinimalPerf.default 471 463 1.02:1
CarouselMinimalPerf.default 531 521 1.02:1
CheckboxMinimalPerf.default 3064 3012 1.02:1
HeaderMinimalPerf.default 425 418 1.02:1
ImageMinimalPerf.default 438 429 1.02:1
ListWith60ListItems.default 734 721 1.02:1
ReactionMinimalPerf.default 444 437 1.02:1
SegmentMinimalPerf.default 411 403 1.02:1
ButtonSlotsPerf.default 652 647 1.01:1
DividerMinimalPerf.default 421 417 1.01:1
EmbedMinimalPerf.default 4604 4560 1.01:1
ListCommonPerf.default 735 730 1.01:1
MenuButtonMinimalPerf.default 1854 1835 1.01:1
TextMinimalPerf.default 414 411 1.01:1
FlexMinimalPerf.default 326 325 1:1
LoaderMinimalPerf.default 758 756 1:1
MenuMinimalPerf.default 952 948 1:1
SplitButtonMinimalPerf.default 4736 4721 1:1
StatusMinimalPerf.default 766 766 1:1
TableManyItemsPerf.default 2207 2202 1:1
CustomToolbarPrototype.default 4375 4364 1:1
ToolbarMinimalPerf.default 1068 1063 1:1
DatepickerMinimalPerf.default 6207 6298 0.99:1
FormMinimalPerf.default 474 479 0.99:1
ProviderMergeThemesPerf.default 1833 1857 0.99:1
AttachmentSlotsPerf.default 1192 1212 0.98:1
ProviderMinimalPerf.default 1168 1192 0.98:1
SliderMinimalPerf.default 1748 1782 0.98:1
IconMinimalPerf.default 677 696 0.97:1
TreeWith60ListItems.default 195 201 0.97:1
ChatWithPopoverPerf.default 404 427 0.95:1
RosterPerf.default 1294 1355 0.95:1
AccordionMinimalPerf.default 180 197 0.91:1

@eljefe223 eljefe223 merged commit e156f24 into microsoft:master Aug 30, 2021
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/web-components@v1.3.8 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants