Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(web-components): fix tree view selection bug #20105

Conversation

chrisdholt
Copy link
Member

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Updates package version to ensure latest changes result in the correct selection of tree items.

Focus areas to test

(optional)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 5, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1e78c9d:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Oct 5, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 7f242dd358714a8f93a20c853629b2a985fc4193 (build)

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-accordion
Accordion (including children components)
55.059 kB
17.394 kB
react-avatar
Avatar
54.953 kB
15.667 kB
react-badge
Badge
23.182 kB
6.986 kB
react-badge
CounterBadge
25.642 kB
7.682 kB
react-badge
PresenseBadge
237 B
177 B
react-button
Button
23.224 kB
7.219 kB
react-button
CompoundButton
28.481 kB
8.173 kB
react-button
MenuButton
25.249 kB
7.895 kB
react-button
SplitButton
30.737 kB
8.955 kB
react-button
ToggleButton
32.45 kB
7.868 kB
react-card
Card - All
13.471 kB
5.068 kB
react-card
Card
9.317 kB
3.925 kB
react-card
CardFooter
8.468 kB
3.557 kB
react-card
CardHeader
9.695 kB
3.99 kB
react-card
CardPreview
8.783 kB
3.741 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
161.95 kB
46.181 kB
react-components
react-components: FluentProvider & webLightTheme
32.188 kB
10.658 kB
react-divider
Divider
15.342 kB
5.585 kB
react-image
Image
9.771 kB
3.975 kB
react-input
Input
31.28 kB
11.294 kB
react-label
Label
8.952 kB
3.708 kB
react-link
Link
11.402 kB
4.59 kB
react-make-styles
makeStaticStyles (runtime)
7.59 kB
3.321 kB
react-make-styles
makeStyles + mergeClasses (runtime)
22.136 kB
8.357 kB
react-make-styles
makeStyles + mergeClasses (build time)
2.558 kB
1.204 kB
react-menu
Menu (including children components)
103.316 kB
31.501 kB
react-menu
Menu (including selectable components)
105.592 kB
31.866 kB
react-popover
Popover
101.153 kB
30.37 kB
react-portal
Portal
6.725 kB
2.237 kB
react-positioning
usePopper
23.145 kB
7.942 kB
react-provider
FluentProvider
15.147 kB
5.573 kB
react-slider
RangedSlider
35.092 kB
10.615 kB
react-slider
Slider
32.072 kB
10.166 kB
react-switch
Switch
23.89 kB
7.842 kB
react-text
Text - Default
11.338 kB
4.418 kB
react-text
Text - Wrappers
14.407 kB
4.724 kB
react-theme
Teams: all themes
25.712 kB
6.17 kB
react-theme
Teams: Light theme
17.215 kB
5.116 kB
react-tooltip
Tooltip
45.543 kB
15.541 kB
react-utilities
SSRProvider
213 B
170 B
🤖 This report was generated against 7f242dd358714a8f93a20c853629b2a985fc4193

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 922 913 5000
BaseButton mount 938 921 5000
Breadcrumb mount 2652 2654 1000
ButtonNext mount 511 508 5000
Checkbox mount 1538 1573 5000
CheckboxBase mount 1326 1330 5000
ChoiceGroup mount 4816 4724 5000
ComboBox mount 982 1014 1000
CommandBar mount 10255 10298 1000
ContextualMenu mount 6523 6515 1000
DefaultButton mount 1161 1162 5000
DetailsRow mount 3793 3811 5000
DetailsRowFast mount 3814 3875 5000
DetailsRowNoStyles mount 3633 3626 5000
Dialog mount 2453 2511 1000
DocumentCardTitle mount 172 177 1000
Dropdown mount 3232 3297 5000
FluentProviderNext mount 3433 3433 5000
FluentProviderWithTheme mount 220 221 10
FluentProviderWithTheme virtual-rerender 110 98 10
FluentProviderWithTheme virtual-rerender-with-unmount 241 253 10
FocusTrapZone mount 1856 1845 5000
FocusZone mount 1824 1804 5000
IconButton mount 1761 1770 5000
Label mount 355 363 5000
Layer mount 3000 2931 5000
Link mount 477 500 5000
MakeStyles mount 1885 1851 50000
MenuButton mount 1461 1517 5000
MessageBar mount 1993 2053 5000
Nav mount 3360 3277 1000
OverflowSet mount 1118 1124 5000
Panel mount 2439 2377 1000
Persona mount 858 847 1000
Pivot mount 1435 1492 1000
PrimaryButton mount 1308 1318 5000
Rating mount 7783 7655 5000
SearchBox mount 1337 1327 5000
Shimmer mount 2562 2548 5000
Slider mount 1981 1995 5000
SpinButton mount 5098 5027 5000
Spinner mount 455 446 5000
SplitButton mount 3195 3432 5000
Stack mount 537 520 5000
StackWithIntrinsicChildren mount 1714 1749 5000
StackWithTextChildren mount 4669 4731 5000
SwatchColorPicker mount 10462 10390 5000
Tabs mount 1465 1450 1000
TagPicker mount 2610 2702 5000
TeachingBubble mount 13029 13121 5000
Text mount 444 445 5000
TextField mount 1395 1400 5000
ThemeProvider mount 1219 1217 5000
ThemeProvider virtual-rerender 629 643 5000
ThemeProvider virtual-rerender-with-unmount 1926 1913 5000
Toggle mount 828 830 5000
buttonNative mount 141 151 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TreeWith60ListItems.default 188 172 1.09:1
HeaderMinimalPerf.default 380 352 1.08:1
AvatarMinimalPerf.default 206 192 1.07:1
GridMinimalPerf.default 355 333 1.07:1
ImageMinimalPerf.default 388 366 1.06:1
IconMinimalPerf.default 626 589 1.06:1
AccordionMinimalPerf.default 159 153 1.04:1
AnimationMinimalPerf.default 421 406 1.04:1
ButtonMinimalPerf.default 178 171 1.04:1
ChatDuplicateMessagesPerf.default 308 296 1.04:1
DividerMinimalPerf.default 365 352 1.04:1
LabelMinimalPerf.default 392 377 1.04:1
LayoutMinimalPerf.default 383 367 1.04:1
ListMinimalPerf.default 522 504 1.04:1
PortalMinimalPerf.default 189 181 1.04:1
ChatWithPopoverPerf.default 388 375 1.03:1
FlexMinimalPerf.default 286 277 1.03:1
PopupMinimalPerf.default 615 599 1.03:1
TreeMinimalPerf.default 813 792 1.03:1
CardMinimalPerf.default 551 542 1.02:1
DialogMinimalPerf.default 771 754 1.02:1
ListCommonPerf.default 629 616 1.02:1
ListNestedPerf.default 566 553 1.02:1
ListWith60ListItems.default 683 671 1.02:1
ToolbarMinimalPerf.default 951 936 1.02:1
AttachmentMinimalPerf.default 164 162 1.01:1
BoxMinimalPerf.default 342 339 1.01:1
ButtonOverridesMissPerf.default 1825 1807 1.01:1
CarouselMinimalPerf.default 477 473 1.01:1
CheckboxMinimalPerf.default 2771 2753 1.01:1
ProviderMergeThemesPerf.default 1763 1748 1.01:1
ProviderMinimalPerf.default 1135 1125 1.01:1
SliderMinimalPerf.default 1713 1700 1.01:1
SplitButtonMinimalPerf.default 4303 4274 1.01:1
TableMinimalPerf.default 415 412 1.01:1
CustomToolbarPrototype.default 4164 4103 1.01:1
ButtonSlotsPerf.default 557 557 1:1
DatepickerMinimalPerf.default 5527 5512 1:1
DropdownManyItemsPerf.default 690 692 1:1
EmbedMinimalPerf.default 4315 4325 1:1
FormMinimalPerf.default 401 402 1:1
HeaderSlotsPerf.default 755 755 1:1
MenuButtonMinimalPerf.default 1679 1680 1:1
RadioGroupMinimalPerf.default 450 452 1:1
RefMinimalPerf.default 239 240 1:1
TableManyItemsPerf.default 1895 1899 1:1
TextMinimalPerf.default 353 352 1:1
TextAreaMinimalPerf.default 499 498 1:1
TooltipMinimalPerf.default 1035 1033 1:1
AttachmentSlotsPerf.default 1046 1057 0.99:1
DropdownMinimalPerf.default 3220 3242 0.99:1
ItemLayoutMinimalPerf.default 1217 1230 0.99:1
LoaderMinimalPerf.default 709 719 0.99:1
MenuMinimalPerf.default 847 854 0.99:1
RosterPerf.default 1184 1192 0.99:1
StatusMinimalPerf.default 673 678 0.99:1
ChatMinimalPerf.default 650 665 0.98:1
InputMinimalPerf.default 1324 1357 0.98:1
AlertMinimalPerf.default 270 278 0.97:1
SkeletonMinimalPerf.default 347 356 0.97:1
VideoMinimalPerf.default 580 596 0.97:1
ReactionMinimalPerf.default 373 389 0.96:1
SegmentMinimalPerf.default 340 354 0.96:1

@chrisdholt chrisdholt merged commit de0266f into microsoft:master Oct 5, 2021
@chrisdholt chrisdholt deleted the users/chhol/fix-tree-view-selection-bug branch October 5, 2021 03:03
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
* fix issue where tree item selection was being impacted due to event issues

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants