Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Panel's Overlay in high contrast mode #7155

Merged
merged 2 commits into from
Nov 21, 2018

Conversation

aneeshack4
Copy link
Contributor

@aneeshack4 aneeshack4 commented Nov 20, 2018

Pull request checklist

Description of changes

Fixing background color of overlay so that screen behind panel isn't hidden in HC mode when panel's open. This is what it looks like now with the overlay's background set to transparent. If I can improve this in any way, please let me know! I just took a shot at it with setting the overlay's background color to transparent.

image

Focus areas to test

The different high contrast modes on Edge (and Firefox too?)

Microsoft Reviewers: Open in CodeFlow

@Jahnp
Copy link
Member

Jahnp commented Nov 20, 2018

Tagging @betrue-final-final when he has a sec for HC issues. This looks good to me, and I believe follows the patterns we have for other modal components (e.g. dialog)

@betrue-final-final
Copy link
Member

For now this makes sense, but I'd like to investigate whether the opposite is in fact the better design for people with low vision.

@Jahnp
Copy link
Member

Jahnp commented Nov 20, 2018

I totally agree! I could see a case to be made for treating modal experiences as "focused" ones where it's standard to hide the background. I feel like this has been discussed before... would be a good HIG topic :)

@aneeshack4 aneeshack4 merged commit 7091f0e into microsoft:master Nov 21, 2018
@msft-github-bot
Copy link
Contributor

🎉office-ui-fabric-react@v6.106.3 has been released which incorporates this pull request.:tada:

Handy Links:

@betrue-final-final
Copy link
Member

Now that I have had time to think about this it may be alarming if the background disappears. Part of the purpose of panels and dialogs is to keep context. A thicker border may be a good improvement.

@kkjeer kkjeer mentioned this pull request Apr 4, 2019
2 tasks
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panel: Overlay not transparent in high contrast mode
4 participants