fix for Issue# 7192 - Slider is broken in IE 11 because it uses parseFloat #7219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
KevinTCoughlin
approved these changes
Nov 27, 2018
There was a problem hiding this comment.
@aftab-hassan can you adjust the vertical example to have an upper bound of 5 not 3 also? This will likely require another snapshot regen.
IE Screenshot
Otherwise, LGTM 👍 -- nice fix!
cliffkoh
approved these changes
Nov 27, 2018
|
🎉 Handy Links: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Slider component: Number.parseFloat() method is not supported in IE11. The fix was to use parseFloat() method instead.
Focus areas to test
Go to the demo page and click the Slider tab. Sliding the slider now works on IE11 after the fix
Microsoft Reviewers: Open in CodeFlow