Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabric Website: Add section under "Developer resources" with link to versioned release notes and demos #9112

Merged

Conversation

KevinTCoughlin
Copy link
Member

@KevinTCoughlin KevinTCoughlin commented May 15, 2019

Pull request checklist

  • Include a change request file using $ npm run change

Description of changes

Adds section under "Developer resources" which links to https://aka.ms/FabricDemo. We want to use this section to educate third-party developers, specifically SharePoint developers about:

  1. Versioned release notes
  2. Versioned component demos
  3. Versioned TypeScript compatibility (Coming soon to https://aka.ms/FabricDemo)

I defer to area owners re: page structure and language. I can clump under a different section if deemed appropriate.

Also whether or not we use aka.ms link vs absolute. The current aka.ms vanity URL is a bit confusing so I can see us preferring absolute URL if we bless this.

Focus areas to test

image

Microsoft Reviewers: Open in CodeFlow

@aditima
Copy link
Contributor

aditima commented May 15, 2019

Love this, @KevinTCoughlin. It would be very helpful to surface this link for SP dev partners.

@ecraig12345
Copy link
Member

Not sure quite what you mean about the current aka.ms URL being confusing?

@KevinTCoughlin
Copy link
Member Author

KevinTCoughlin commented May 15, 2019

Not sure quite what you mean about the current aka.ms URL being confusing?

In case anyone minds that the vanity url is "FabricDemo" and this PR states the link points to "Release notes and demos". Doubt many would see or care tho, I don't mind.

Overloaded was probably the term I was looking for.

@msft-github-bot
Copy link
Contributor

msft-github-bot commented May 15, 2019

Component perf results:

Scenario Target branch avg total (ms) PR avg total (ms) Target branch avg per item (ms) PR avg per item (ms) Is significant change Is regression
PrimaryButton 84.128 85.171 0.841 0.852 false false
BaseButton 33.565 34.759 0.336 0.348 false false
NewButton 121.263 123.230 1.213 1.232 false false
button 5.267 5.854 0.053 0.058 true true
DetailsRows without styles 194.662 195.439 1.947 1.954 false false
DetailsRows 218.902 228.659 2.189 2.287 true true
Toggles 53.254 54.938 0.532 0.549 false false
NewToggle 73.412 74.723 0.734 0.747 false false
DocumentCardTitle with truncation 27.576 28.994 0.276 0.290 false false

@size-auditor
Copy link

size-auditor bot commented May 15, 2019

Size Auditor did not detect a change in bundle size for any component!

@ecraig12345
Copy link
Member

In case anyone minds that the vanity url is "FabricDemo" and this PR states the link points to "Release notes and demos". Doubt many would see or care tho, I don't mind.

Overloaded was probably the term I was looking for.

I think the link is fine as-is, especially since the URL isn't displayed on the page and it will redirect as soon as the users click it. It's also nice in case we ever want to move the demo site to a different location (then we'd only have to update the aka link).

Copy link
Member

@ecraig12345 ecraig12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor suggestion

@Jahnp
Copy link
Member

Jahnp commented May 15, 2019

Agreed, looks great to me. Good improvement @KevinTCoughlin !

…ault/ResourcesDeveloperResources.md

Co-Authored-By: Elizabeth Craig <ecraig12345@gmail.com>
@msft-github-bot
Copy link
Contributor

Hello @KevinTCoughlin!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that is not currently met. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me and give me an instruction to get started! Learn more here.

@msft-github-bot msft-github-bot merged commit d80271e into microsoft:master May 16, 2019
@msft-github-bot
Copy link
Contributor

🎉@uifabric/fabric-website@v6.18.4 has been released which incorporates this pull request.:tada:

Handy links:

@KevinTCoughlin KevinTCoughlin deleted the keco/release-notes-link branch May 17, 2019 14:28
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants