-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fabric Website: Add section under "Developer resources" with link to versioned release notes and demos #9112
Fabric Website: Add section under "Developer resources" with link to versioned release notes and demos #9112
Conversation
Love this, @KevinTCoughlin. It would be very helpful to surface this link for SP dev partners. |
Not sure quite what you mean about the current aka.ms URL being confusing? |
In case anyone minds that the vanity url is "FabricDemo" and this PR states the link points to "Release notes and demos". Doubt many would see or care tho, I don't mind. Overloaded was probably the term I was looking for. |
Component perf results:
|
Size Auditor did not detect a change in bundle size for any component! |
I think the link is fine as-is, especially since the URL isn't displayed on the page and it will redirect as soon as the users click it. It's also nice in case we ever want to move the demo site to a different location (then we'd only have to update the aka link). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one minor suggestion
...fabric-website/src/pages/Overviews/ResourcesPage/docs/default/ResourcesDeveloperResources.md
Outdated
Show resolved
Hide resolved
Agreed, looks great to me. Good improvement @KevinTCoughlin ! |
…ault/ResourcesDeveloperResources.md Co-Authored-By: Elizabeth Craig <ecraig12345@gmail.com>
Hello @KevinTCoughlin! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that is not currently met. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me and give me an instruction to get started! Learn more here. |
🎉 Handy links: |
Pull request checklist
$ npm run change
Description of changes
Adds section under "Developer resources" which links to https://aka.ms/FabricDemo. We want to use this section to educate third-party developers, specifically SharePoint developers about:
I defer to area owners re: page structure and language. I can clump under a different section if deemed appropriate.
Also whether or not we use aka.ms link vs absolute. The current aka.ms vanity URL is a bit confusing so I can see us preferring absolute URL if we bless this.
Focus areas to test
Microsoft Reviewers: Open in CodeFlow