Dropdown: Update some palette to use semantic slots instead #9182
Conversation
|
@msft-github-bot whenever github gets back to a healthy state, please make sure @phkuo signs off. |
cliffkoh
changed the title
| @@ -218,15 +218,15 @@ export const getStyles: IStyleFunction<IDropdownStyleProps, IDropdownStyles> = p | |||
| ], | |||
| caretDown: [ | |||
| globalClassnames.caretDown, | |||
| { color: palette.neutralSecondary, fontSize: FontSizes.small, pointerEvents: 'none' }, | |||
| { color: semanticColors.inputPlaceholderText, fontSize: FontSizes.small, pointerEvents: 'none' }, | |||
There was a problem hiding this comment.
not a fan of this, but can't find something more appropriate
There was a problem hiding this comment.
maybe bodySubtext? (or a menuItem equivalent of it)
There was a problem hiding this comment.
There is nothing in menu that maps to neutralSecondary, but I will change to bodySubtext. Thanks for the suggestion!
There was a problem hiding this comment.
@cliffkoh this is exactly why I we need designers to help us out with this kind of issues by making a pass through all semantic slots and create redlines for each component in pointing the correct usage of these slots. It might be very possible that ew end up with new slots addition but we should be very careful with it.
There was a problem hiding this comment.
yeah you might want to add a menu item version of bodySubtext at some point
There was a problem hiding this comment.
bodySubtext is only going to work while the menuBackground and bodyBackground are the same
There was a problem hiding this comment.
Should I delay merging this PR? Or at least revert these two lines of more contentious changes?
There was a problem hiding this comment.
up to you. currently there are no themes that customize semantic slots so this is only a theoretical issue
packages/office-ui-fabric-react/src/components/Dropdown/Dropdown.styles.ts
Outdated
Show resolved
Hide resolved
|
Hello @cliffkoh! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that is not currently met. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Hello @cliffkoh! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
|
Component perf results:
|
|
|
🎉 Handy links: |
Pull request checklist
$ npm run changeDescription of changes
This PR attempts to reduce the amount of palette slot usage and replace with semantic slots in Dropdown.
Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow