Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect changelog entries for OUFR #9630

Merged
merged 1 commit into from
Jun 28, 2019

Conversation

cliffkoh
Copy link
Contributor

@cliffkoh cliffkoh commented Jun 28, 2019

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ npm run change

Description of changes

Fix broken changelogs.

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

@msft-github-bot
Copy link
Contributor

Hello @cliffkoh!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msft-github-bot) and give me an instruction to get started! Learn more here.

@cliffkoh
Copy link
Contributor Author

@msft-github-bot merge this after 20 minutes.

@msft-github-bot
Copy link
Contributor

Hello @cliffkoh!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Fri, 28 Jun 2019 22:41:30 GMT, which is in 20 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@dzearing dzearing merged commit 3b9e492 into microsoft:master Jun 28, 2019
@cliffkoh cliffkoh deleted the cliffkoh/fixChangelog branch June 28, 2019 22:23
@size-auditor
Copy link

size-auditor bot commented Jun 28, 2019

Bundle test Size (minified) Diff from master
Pickers 293.615 kB ExceedsTolerance     293.615 kB
ComboBox 254.937 kB ExceedsTolerance     254.937 kB
ShimmeredDetailsList 254.789 kB ExceedsTolerance     254.789 kB
FloatingPicker 253.408 kB ExceedsTolerance     253.408 kB
Dropdown 244.41 kB ExceedsTolerance     244.41 kB
DetailsList 243.609 kB ExceedsTolerance     243.609 kB
SelectedItemsList 243.603 kB ExceedsTolerance     243.603 kB
DatePicker 233.505 kB ExceedsTolerance     233.505 kB
DocumentCard 230.708 kB ExceedsTolerance     230.708 kB
Facepile 226.881 kB ExceedsTolerance     226.881 kB
Dialog 223.374 kB ExceedsTolerance     223.374 kB
CommandBar 216.833 kB ExceedsTolerance     216.833 kB
Panel 215.621 kB ExceedsTolerance     215.621 kB
Breadcrumb 214.786 kB ExceedsTolerance     214.786 kB
SpinButton 209.942 kB ExceedsTolerance     209.942 kB
Button 209.671 kB ExceedsTolerance     209.671 kB
SwatchColorPicker 209.452 kB ExceedsTolerance     209.452 kB
TeachingBubble 208.703 kB ExceedsTolerance     208.703 kB
MessageBar 206.184 kB ExceedsTolerance     206.184 kB
Nav 205.84 kB ExceedsTolerance     205.84 kB
Pivot 204.811 kB ExceedsTolerance     204.811 kB
SearchBox 203.914 kB ExceedsTolerance     203.914 kB
Grid 199.622 kB ExceedsTolerance     199.622 kB
ContextualMenu 180.151 kB ExceedsTolerance     180.151 kB
Calendar 177.633 kB ExceedsTolerance     177.633 kB
GroupedList 153.173 kB ExceedsTolerance     153.173 kB
Persona 147.841 kB ExceedsTolerance     147.841 kB
PersonaCoin 147.841 kB ExceedsTolerance     147.841 kB
KeytipLayer 135.112 kB ExceedsTolerance     135.112 kB
HoverCard 131.604 kB ExceedsTolerance     131.604 kB
Coachmark 129.807 kB ExceedsTolerance     129.807 kB
Modal 125.808 kB ExceedsTolerance     125.808 kB
experiments-Button 125.703 kB ExceedsTolerance     125.703 kB
Tooltip 121.646 kB ExceedsTolerance     121.646 kB
ExtendedPicker 120.379 kB ExceedsTolerance     120.379 kB
ColorPicker 116.926 kB ExceedsTolerance     116.926 kB
Rating 116.693 kB ExceedsTolerance     116.693 kB
Callout 116.675 kB ExceedsTolerance     116.675 kB
ActivityItem 113.525 kB ExceedsTolerance     113.525 kB
Keytip 112.802 kB ExceedsTolerance     112.802 kB
TextField 109.341 kB ExceedsTolerance     109.341 kB
PositioningContainer 109.282 kB ExceedsTolerance     109.282 kB
MarqueeSelection 109.009 kB ExceedsTolerance     109.009 kB
Icons 106.558 kB ExceedsTolerance     106.558 kB
Utilities 100.466 kB ExceedsTolerance     100.466 kB
PersonaPresence 99.493 kB ExceedsTolerance     99.493 kB
Slider 98.387 kB ExceedsTolerance     98.387 kB
Shimmer 97.959 kB ExceedsTolerance     97.959 kB
Checkbox 96.057 kB ExceedsTolerance     96.057 kB
ScrollablePane 95.805 kB ExceedsTolerance     95.805 kB
Toggle 95.795 kB ExceedsTolerance     95.795 kB
ChoiceGroup 95.338 kB ExceedsTolerance     95.338 kB
ChoiceGroupOption 90.271 kB ExceedsTolerance     90.271 kB
OverflowSet 90.094 kB ExceedsTolerance     90.094 kB
Link 89.691 kB ExceedsTolerance     89.691 kB
Spinner 88.698 kB ExceedsTolerance     88.698 kB
Overlay 87.731 kB ExceedsTolerance     87.731 kB
Check 85.888 kB ExceedsTolerance     85.888 kB
Layer 82.981 kB ExceedsTolerance     82.981 kB
Icon 82.688 kB ExceedsTolerance     82.688 kB
Image 80.55 kB ExceedsTolerance     80.55 kB
Stack 78.523 kB ExceedsTolerance     78.523 kB
Styling 77.791 kB ExceedsTolerance     77.791 kB
ProgressIndicator 77.034 kB ExceedsTolerance     77.034 kB
Fabric 76.714 kB ExceedsTolerance     76.714 kB
Announced 76.411 kB ExceedsTolerance     76.411 kB
Label 76.321 kB ExceedsTolerance     76.321 kB
Selection 75.941 kB ExceedsTolerance     75.941 kB
Foundation 75.563 kB ExceedsTolerance     75.563 kB
Text 74.497 kB ExceedsTolerance     74.497 kB
List 74.234 kB ExceedsTolerance     74.234 kB
FocusZone 68.168 kB ExceedsTolerance     68.168 kB
Autofill 58.497 kB ExceedsTolerance     58.497 kB
ResizeGroup 57.082 kB ExceedsTolerance     57.082 kB
Sticky 56.454 kB ExceedsTolerance     56.454 kB
Separator 53.965 kB ExceedsTolerance     53.965 kB
Divider 52.469 kB ExceedsTolerance     52.469 kB
Popup 50.144 kB ExceedsTolerance     50.144 kB
FocusTrapZone 49.993 kB ExceedsTolerance     49.993 kB
ThemeGenerator 49.19 kB ExceedsTolerance     49.19 kB
KeytipData 46.811 kB ExceedsTolerance     46.811 kB
Color 46.126 kB ExceedsTolerance     46.126 kB
SelectableOption 35.428 kB ExceedsTolerance     35.428 kB

ExceedsTolerance  Exceeds Tolerance     ExceedsBaseline  Exceeds Baseline     BelowBaseline  Below Baseline     1 kB = 1000 bytes

gingeroun pushed a commit to gingeroun/office-ui-fabric-react that referenced this pull request Jul 5, 2019
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants