[Cherry-pick] withViewport: Fix stale viewport calculation when toggling skipViewportMeasure #9646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtMeasure (microsoft#9565) * withViewport: recalculate viewport if skipViewportMeasures has become falsey * Add change file * Fix document library row regression * memoize sum column widths * Rm debug * Update API * Update common/changes/office-ui-fabric-react/keco-withViewport-recalc_2019-06-25-00-02.json * Refactor rowWidth to IDetailsItemProps * Fix and re-enable onColumnResize test * Update DetailsList examples to use layoutMode justified for full width * Update snapshots
KevinTCoughlin
changed the title
ThomasMichon
approved these changes
Jul 1, 2019
|
|
Component Perf Analysis:
|
|
Hello @KevinTCoughlin! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 23 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
gingeroun
pushed a commit
to gingeroun/office-ui-fabric-react
that referenced
this pull request
Jul 5, 2019
…rtMeasure (microsoft#9565) (microsoft#9646) * withViewport: recalculate viewport if skipViewportMeasures has become falsey * Add change file * Fix document library row regression * memoize sum column widths * Rm debug * Update API * Update common/changes/office-ui-fabric-react/keco-withViewport-recalc_2019-06-25-00-02.json * Refactor rowWidth to IDetailsItemProps * Fix and re-enable onColumnResize test * Update DetailsList examples to use layoutMode justified for full width * Update snapshots
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #9565 into
7.x. See linked PR for description.Microsoft Reviewers: Open in CodeFlow