Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating macOS runner version #668

Merged
merged 3 commits into from
Dec 27, 2022
Merged

Conversation

mshr-h
Copy link
Collaborator

@mshr-h mshr-h commented Dec 21, 2022

@mshr-h mshr-h mentioned this pull request Dec 21, 2022
2 tasks
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2022

Codecov Report

Merging #668 (49f9d12) into main (41aae4b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #668   +/-   ##
=======================================
  Coverage   90.24%   90.24%           
=======================================
  Files          78       78           
  Lines        4543     4543           
  Branches      839      839           
=======================================
  Hits         4100     4100           
  Misses        252      252           
  Partials      191      191           
Flag Coverage Δ
unittests 90.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mshr-h
Copy link
Collaborator Author

mshr-h commented Dec 21, 2022

Python 3.8 failed with the following warning message. But no similar message on 3.9 and 3.10.
Is Python 3.8 on GitHub Actions compiled on older macOS?

Warning: st.macosx-10.15-x86_64/wheel/tvm/libtvm_runtime.dylib[WARNING] This wheel needs a higher macOS version than the version your Python interpreter is compiled against. To silence this warning, set MACOSX_DEPLOYMENT_TARGET to at least 12_0 or recreate these files with lower MACOSX_DEPLOYMENT_TARGET:

@mshr-h
Copy link
Collaborator Author

mshr-h commented Dec 23, 2022

TVM build on macOS is pretty freaky.

@mshr-h mshr-h force-pushed the update-macos-ver branch 3 times, most recently from 64288b4 to a4cef4d Compare December 23, 2022 10:15
@mshr-h
Copy link
Collaborator Author

mshr-h commented Dec 26, 2022

Maybe this is the cause.

@mshr-h
Copy link
Collaborator Author

mshr-h commented Dec 27, 2022

The TVM build error on macOS is now fixed.

@ksaur @interesaaat
Can you review it?
There are still macOS-11 pipeline checks. I don't know how to solve it.

@mshr-h mshr-h marked this pull request as ready for review December 27, 2022 09:02
@interesaaat
Copy link
Collaborator

I can solve them. Thanks for saving us the pain of upgrading mac!

@interesaaat interesaaat merged commit ef48e01 into microsoft:main Dec 27, 2022
@mshr-h mshr-h deleted the update-macos-ver branch December 28, 2022 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants