Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sharing application errors (build, linters, analyzers, etc.) with guests #133

Closed
dsplaisted opened this issue Mar 13, 2018 · 4 comments

Comments

@dsplaisted
Copy link
Member

Product and Version: VS and VS Code
OS Version: Windows and Mac OS
Live Share Extension Version: 0.2.133.57639 on VS
Target Platform or Language: .NET

Steps to Reproduce / Scenario:

  1. Share a project that uses XUnit from VS to VS Code
  2. Write a public method in a test class without putting a Fact attribute on it.
  3. You should get an error from the XUnit analyzers saying that you need a Fact attribute on the method.

EXPECTED: XUnit analyzer error is show on guest VS Code instance
ACTUAL: No error shown in VS Code

@lostintangent
Copy link
Member

@dsplaisted Thanks for the feedback! We've been tracking this work alongside #48, but as you mentioned, errors are much broader than just build, so it makes sense to have a separate work item. Additionally, we need to support the equivalent experience in VS Code, so I'll generalize this issue, and we can use it to track progress moving forward.

@lostintangent lostintangent self-assigned this Mar 13, 2018
@lostintangent lostintangent changed the title Errors from Roslyn Analyzers are not shared over VS Live Share Support sharing the error list with guests Mar 13, 2018
@srivatsn
Copy link

We'll need to make sure that the squiggles in the editor are also synced (since atleast in VS the mechanism for the squiggles and error list are disjoint)

@lostintangent lostintangent changed the title Support sharing the error list with guests Support sharing application errors (build, linters, analyzers, etc.) with guests Mar 13, 2018
@lostintangent
Copy link
Member

lostintangent commented Mar 13, 2018

@srivatsn Good point! I just updated the title to be even more general, since the context we want to share is errors, and the expected impact on the guests-side is a populated error list and editor squiggles.

@lostintangent
Copy link
Member

Since the repro steps in this bug are specific to XUnit, and we've had another bug filed for the general issue of not sharing errors, I'm going to close this in favor of a new bug that can be the catch-all for this feature request (#165).

I referenced this bug and #141 from the new issue, but let me know if I didn't capture any of the details correctly. Thanks again for reporting this!

Chuxel pushed a commit that referenced this issue May 25, 2019
…s://github.com/microsoftdocs/live-share (branch master) (#133)

* Small tweaks

* Adding insiders doc

* Adding images

* Document liveshare.account and liveshare.accountProvider settings

* Update

* Update profile links (#2089)

* Updating guest limit comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants