Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only share files visible in the "solution view" when sharing from VS #149

Closed
Chuxel opened this issue Mar 19, 2018 · 1 comment
Closed

Comments

@Chuxel
Copy link
Member

Chuxel commented Mar 19, 2018

Currently when a solution is shared in VS, the folder structure under the solution is also shared. It is essentially what you would see if you clicked the "Solutions and Folders" button and switched to "Folder view" in VS.

image

(Note: See #31 on supporting "solution view" for the guest and #46 on supporting projects outside of the solution root for these problems.)

Solution View:

image

Folder View, what Guest Sees:
image

In most cases this is fine as it provides the "guest" with a full picture of the project structure. However, what is shared can be a bit unexpected given the "host" shared from a view that may have hid a number of files or folders. For example, "test12354.txt" above was not in the visible in "solution view" and thus the host may not have realized it was shared.

In addition to allowing users to specify certain files or folders as "host only" (#52) and thus not visible to guests we could automatically only share files visible in the solution explorer when the host shares while "solution view" rather than what is visible in folder view to keep things consistent.

@Chuxel Chuxel changed the title Only share files visible in the "solution view" if visible when sharing from VS Only share files visible in the "solution view" when sharing from VS Mar 19, 2018
@lostintangent
Copy link
Member

This has been resolved as part of the fact that "Solution view" is now supported in Visual Studio.

Chuxel pushed a commit that referenced this issue Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants