Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add error message for libssl1.1 on Ubuntu 22.04 #4742

Conversation

dariuszparys
Copy link
Contributor

On Ubuntu 22.04 the libssl1.1 command currently fails without any intervention
This is now checked if libssl1.1 install fails and will print the alternate
installation method of libssl1.1 which basically means

  1. Adding deb http://security.ubuntu.com/ubuntu focal-security main to /etc/apt/sources.list
  2. Running apt update to include the source

This will resolve #4741 and probably #4710, #4646, #4678

The solution described by @ermshiperete here #4741 (comment) should also be into consideration, but I haven't tested it for the whole suite of distributions.

On Ubuntu 22.04 the libssl1.1 command currently fails without any intervention
This is now checked and will print the alternate
installation method of libssl1.1 which basically means

1. Adding `deb http://security.ubuntu.com/ubuntu focal-security main` to `/etc/apt/sources.list`
2. Running `apt update` to include the source
@dariuszparys
Copy link
Contributor Author

@alyssajotice please have a look at this PR

Copy link
Contributor

@alyssajotice alyssajotice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alyssajotice alyssajotice merged commit 193da72 into microsoft:main Aug 22, 2022
@alyssajotice
Copy link
Contributor

@dariuszparys, thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vsls-reqs doesn't fail if it can't install libssl1.1
3 participants