Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention removal of IResourceCreate, IResourceEdit, and IResourceRename in the changelog #761

Closed
rcjsuen opened this issue Mar 14, 2018 · 2 comments
Assignees
Milestone

Comments

@rcjsuen
Copy link
Contributor

rcjsuen commented Mar 14, 2018

IResourceCreate, IResourceEdit, and IResourceRename were all removed in 0.11 but not mentioned as a breaking change in the changelog. WorkspaceEdit was also updated to reflect the new changes.

These changes were introduced in microsoft/vscode@dc31fa2.

@alexdima alexdima added this to the February 2018 milestone Mar 15, 2018
@alexdima alexdima self-assigned this Mar 15, 2018
@alexdima
Copy link
Member

IResourceCreate, IResourceEdit, and IResourceRename were never released in the monaco editor. Here is the previous monaco.d.ts from 0.10.1.

Unfortunately, 0.11.0 does introduce ResourceFileEdit. To my knowledge that is not honoured by the editor, as the editor rename functionality knows only how to apply ResourceTextEdits and not ResourceFileEdits... I will mention this in the changelog.

@rcjsuen
Copy link
Contributor Author

rcjsuen commented Mar 15, 2018

@alexandrudima I see IResourceEdit in the file you linked to. You are right though that IResourceCreate and IResourceRename cannot be found. Sorry for the confusion.

https://github.com/Microsoft/monaco-editor/blob/2e880e008915b278482f8ee1ddbb3792e5320364/monaco.d.ts#L4795-L4799

alexdima added a commit that referenced this issue Mar 15, 2018
alexdima added a commit that referenced this issue Mar 15, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants