Skip to content
This repository has been archived by the owner on Nov 5, 2021. It is now read-only.

Support better C++ annotation highlighting #125

Merged
merged 2 commits into from
Feb 23, 2021
Merged

Support better C++ annotation highlighting #125

merged 2 commits into from
Feb 23, 2021

Conversation

mattgodbolt
Copy link
Contributor

* Uses some simple highlighting within annotations
* Supports multi-line annotations
  (see compiler-explorer/compiler-explorer#878)
@ghost
Copy link

ghost commented Feb 15, 2021

CLA assistant check
All CLA requirements met.

@mattgodbolt
Copy link
Contributor Author

Hold up: I just realised [ [ this ] ] is valid too. Will at least port the fix from starkmapper/compiler-explorer@f2cdfbb

@mattgodbolt mattgodbolt marked this pull request as draft February 15, 2021 23:31
@mattgodbolt mattgodbolt marked this pull request as ready for review February 15, 2021 23:43
@mattgodbolt
Copy link
Contributor Author

Done, ready. Thanks for your patience, and attention!

@mattgodbolt
Copy link
Contributor Author

Hey friends, µping on this :) Would let us close off a bug in Compiler Explorer and mean we don't monkeypatch our version of monaco :)

@alexdima
Copy link
Member

👍 Thank you!

@alexdima alexdima added this to the vnext milestone Feb 23, 2021
@alexdima alexdima merged commit 8e1692b into microsoft:main Feb 23, 2021
@mattgodbolt mattgodbolt deleted the cpp-annotation-fixes branch February 23, 2021 23:59
@mattgodbolt
Copy link
Contributor Author

Fantastic! Thanks @alexdima :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants