User/masudars/component goverance fixes #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-subtree-dir: lib/xerces git-subtree-split: 6500318cb3d4ea3f6f3591e55e2e8acc9a71cf0e
…ommit hash and the updated web link to a release
…erces CMake files to compile in Android 19 (https://microsoft.visualstudio.com/xPlatAppx/_git/xPlatAppx/commit/cc323b621636306f56c4d4c86d00d9d031ee3bdf)
Madhusudhan-MSFT
requested review from
JohnMcPMS,
msftrubengu and
ranm-msft
as code owners
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
msftrubengu
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes to address Component Governance fixes related to msix-sdk/lib/xerces/src/xercesc/util/PlatformUtils.cpp
The fix includes:
Removing V3.2.0 version of lib/xercesc from the repo
Adding xercesc v3.2.1 tag release to repo as subtree to sub-dir path lib/xercesc (should be same as before). This should only bring version update to xercesc which is a recommended CG fix.
Re-applying edits/commit that were made on top previous tab version v3.2.0 i.e
[How validated:]
Compiled MSIX SDK code for windows x64 arch
ensure everything compiles fine
Executed tests by running test exe for both cases compiled above