Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

API tuning: two minor changes for usability. #29

Merged
merged 2 commits into from
Aug 8, 2017
Merged

Conversation

daiyip
Copy link
Contributor

@daiyip daiyip commented Aug 7, 2017

  1. Make broadcast/execute args optional.
  2. Introduce 'global.napa' to access napajs module.

2. Introduce 'global.napa' to access napajs module.
@msftclas
Copy link

msftclas commented Aug 7, 2017

@daiyip,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@helloshuangzi
Copy link
Contributor

helloshuangzi commented Aug 7, 2017

            var napa = require(napaDir);

we can use "global.napa" here #Resolved


Refers to: test/zone-test.ts:465 in 133c62f. [](commit_id = 133c62f, deletion_comment = False)

@helloshuangzi
Copy link
Contributor

helloshuangzi commented Aug 7, 2017

            var napa = require(napaDir);

the same as above #Resolved


Refers to: test/zone-test.ts:473 in 133c62f. [](commit_id = 133c62f, deletion_comment = False)

@daiyip daiyip merged commit fc94759 into master Aug 8, 2017
@daiyip daiyip deleted the dev/dapeng/api_tunes branch August 8, 2017 00:39
daiyip added a commit that referenced this pull request Jan 19, 2018
1. Make broadcast/execute args optional.
2. Introduce 'global.napa' to access napajs module.
daiyip added a commit that referenced this pull request Jan 19, 2018
1. Make broadcast/execute args optional.
2. Introduce 'global.napa' to access napajs module.
daiyip added a commit that referenced this pull request Jan 19, 2018
1. Make broadcast/execute args optional.
2. Introduce 'global.napa' to access napajs module.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants