Fix Test Executor In VS15 Post Preview 4 #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Bug** The test executor can currently fail in vs15 post preview 4 because it tries to look up the nodejs.targets file in the global msbuild location. We now only install the targets file to the local, vs specific msbuild folder. **Fix** Similar to with the test discoverer, make sure we use the correct msbuild location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
The test executor can currently fail in vs15 post preview 4 because it tries to look up the nodejs.targets file in the global msbuild location. We now only install the targets file to the local, vs specific msbuild folder.
Fix
Similar to the fix we took in for the test discoverer, make sure we use the correct msbuild location. This is passed to the test executor using an environment variable.