Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On-Device Training - Enable loading from buffer #16417

Merged
merged 22 commits into from
Aug 23, 2023

Conversation

askhade
Copy link
Contributor

@askhade askhade commented Jun 19, 2023

Description

This PR contains C and C++ API updates for On Device Training to enable loading all the models from buffer.
Enabling loading from buffer for checkpoint will be done in a separate PR.

Motivation and Context

This is required for web bindings

@baijumeswani baijumeswani added the training issues related to ONNX Runtime training; typically submitted using template label Jun 20, 2023
orttraining/orttraining/training_api/utils.h Outdated Show resolved Hide resolved
orttraining/orttraining/training_api/module.h Outdated Show resolved Hide resolved
orttraining/orttraining/training_api/utils.h Outdated Show resolved Hide resolved
orttraining/orttraining/training_api/optimizer.cc Outdated Show resolved Hide resolved
orttraining/orttraining/training_api/module.h Show resolved Hide resolved
orttraining/orttraining/training_api/module.cc Outdated Show resolved Hide resolved
pengwa
pengwa previously approved these changes Aug 8, 2023
Copy link
Contributor

@pengwa pengwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, besides few minor comments submitted earlier.

pengwa
pengwa previously approved these changes Aug 9, 2023
baijumeswani
baijumeswani previously approved these changes Aug 9, 2023
orttraining/orttraining/training_api/utils.h Show resolved Hide resolved
@askhade askhade dismissed stale reviews from baijumeswani and pengwa via 7197595 August 16, 2023 20:46
baijumeswani
baijumeswani previously approved these changes Aug 18, 2023
@askhade askhade merged commit 56102ec into main Aug 23, 2023
95 checks passed
@askhade askhade deleted the askhade/ODT_enable_loading_from_buffer branch August 23, 2023 02:59
@faxu faxu added the triage:approved Approved for cherrypicks for release label Aug 24, 2023
snnn pushed a commit that referenced this pull request Aug 28, 2023
kleiti pushed a commit to kleiti/onnxruntime that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
training issues related to ONNX Runtime training; typically submitted using template triage:approved Approved for cherrypicks for release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants