-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On-Device Training - Enable loading from buffer #16417
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baijumeswani
added
the
training
issues related to ONNX Runtime training; typically submitted using template
label
Jun 20, 2023
orttraining/orttraining/training_api/include/onnxruntime_training_cxx_api.h
Outdated
Show resolved
Hide resolved
orttraining/orttraining/training_api/onnxruntime_training_c_api.cc
Outdated
Show resolved
Hide resolved
csharp/src/Microsoft.ML.OnnxRuntime/Training/NativeTrainingMethods.shared.cs
Outdated
Show resolved
Hide resolved
pengwa
reviewed
Jul 10, 2023
orttraining/orttraining/training_api/onnxruntime_training_c_api.cc
Outdated
Show resolved
Hide resolved
pengwa
reviewed
Aug 4, 2023
orttraining/orttraining/test/training_api/core/training_capi_tests.cc
Outdated
Show resolved
Hide resolved
baijumeswani
reviewed
Aug 7, 2023
pengwa
previously approved these changes
Aug 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, besides few minor comments submitted earlier.
pengwa
previously approved these changes
Aug 9, 2023
baijumeswani
previously approved these changes
Aug 9, 2023
baijumeswani
previously approved these changes
Aug 18, 2023
pengwa
approved these changes
Aug 21, 2023
pengwa
approved these changes
Aug 23, 2023
centwang
pushed a commit
that referenced
this pull request
Aug 28, 2023
snnn
pushed a commit
that referenced
this pull request
Aug 28, 2023
Cherry-pick 1st round for rel-1.16.0 from https://github.com/microsoft/onnxruntime/issues?q=label%3Arelease%3A1.16+label%3Atriage%3Aapproved+is%3Aclosed except #17201 because it caused UT failure and is not fixed yet. PR list: #16417 #16936 #17000 #17236 #17238 #17240 #17252 #17255 #17258 #17265 #17267 #17277
kleiti
pushed a commit
to kleiti/onnxruntime
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
training
issues related to ONNX Runtime training; typically submitted using template
triage:approved
Approved for cherrypicks for release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains C and C++ API updates for On Device Training to enable loading all the models from buffer.
Enabling loading from buffer for checkpoint will be done in a separate PR.
Motivation and Context
This is required for web bindings