Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cmake to 3.27 and upgrade Linux CUDA docker files from CentOS7 to UBI8 #16856

Merged
merged 75 commits into from
Sep 6, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
75 commits
Select commit Hold shift + click to select a range
7d78384
Update docker files
snnn Jul 25, 2023
46088fe
Update README.md
snnn Jul 25, 2023
bb8f7ef
Add missing file
snnn Jul 26, 2023
9475b17
Merge remote-tracking branch 'origin/main' into snnn/update_docker_files
snnn Aug 10, 2023
bc29da8
update
snnn Aug 10, 2023
007f2cf
Merge remote-tracking branch 'origin/main' into snnn/update_docker_files
snnn Aug 19, 2023
16db4e0
Update cmake to 3.27.3
snnn Aug 19, 2023
bf12e6c
update
snnn Aug 19, 2023
da00288
Update c-api-noopenmp-packaging-pipelines.yml
snnn Aug 30, 2023
9f5661f
Update build_cuda_c_api_package.sh
snnn Aug 30, 2023
0969090
Update c-api-noopenmp-packaging-pipelines.yml
snnn Aug 30, 2023
bbd4d5d
update
snnn Aug 30, 2023
f5e185c
update
snnn Aug 30, 2023
385c57a
update
snnn Aug 30, 2023
718ce57
update
snnn Aug 30, 2023
2cf2d76
update
snnn Aug 30, 2023
8829531
update
snnn Aug 30, 2023
94ea4ee
update
snnn Aug 30, 2023
a9d3560
update
snnn Aug 30, 2023
899cbfe
update
snnn Aug 30, 2023
31fe996
update
snnn Aug 30, 2023
6470e37
update
snnn Aug 30, 2023
40f248e
update
snnn Aug 30, 2023
3ea7114
update
snnn Aug 30, 2023
fff33fb
update
snnn Aug 30, 2023
b493f31
update
snnn Aug 30, 2023
f3a8879
update
snnn Aug 30, 2023
067d2d7
update
snnn Aug 30, 2023
00c2721
change alias
snnn Aug 31, 2023
ae5b798
stashj
snnn Aug 31, 2023
92f4498
Fix a build error: a constexpr function calls a non-constexpr function
snnn Aug 31, 2023
6c23ef0
update
snnn Aug 31, 2023
83706fa
update
snnn Aug 31, 2023
320fc0d
update
snnn Aug 31, 2023
29b7cea
revert
snnn Aug 31, 2023
2e5ea49
Merge remote-tracking branch 'origin/snnn/update_cu' into snnn/update_cu
snnn Aug 31, 2023
50234a4
update
snnn Aug 31, 2023
d493bfc
update
snnn Aug 31, 2023
a099be9
update
snnn Aug 31, 2023
1391ade
update
snnn Aug 31, 2023
90b329d
update
snnn Aug 31, 2023
8cf4e31
update
snnn Aug 31, 2023
ff1f2fc
update
snnn Aug 31, 2023
6fd5309
update
snnn Aug 31, 2023
50820d1
update
snnn Aug 31, 2023
6cd30f0
update
snnn Aug 31, 2023
d87aac5
Merge remote-tracking branch 'origin/main' into snnn/update_cu
snnn Aug 31, 2023
2b9a357
update
snnn Aug 31, 2023
bd77a6e
Merge remote-tracking branch 'origin/main' into snnn/update_cu
snnn Aug 31, 2023
6d132e9
update
snnn Aug 31, 2023
cdbf5af
update
snnn Aug 31, 2023
f9481be
update
snnn Aug 31, 2023
4ed8e0b
update
snnn Aug 31, 2023
e795418
update
snnn Aug 31, 2023
9481f23
update
snnn Sep 1, 2023
615fa05
Merge remote-tracking branch 'origin/snnn/update_cu' into snnn/update…
snnn Sep 1, 2023
748d9e2
update
snnn Sep 1, 2023
8b80c3d
update
snnn Sep 1, 2023
3624c06
Merge remote-tracking branch 'origin/main' into snnn/update_docker_files
snnn Sep 1, 2023
a3155fc
update
snnn Sep 1, 2023
0458ea8
update
snnn Sep 1, 2023
9ed166a
update
snnn Sep 1, 2023
9588c00
update
snnn Sep 1, 2023
ca4d9d8
Merge branch 'snnn/update_docker_files' of https://github.com/microso…
snnn Sep 1, 2023
2dd046b
update
snnn Sep 1, 2023
10e9c5f
Merge remote-tracking branch 'origin/snnn/update_docker_files' into s…
snnn Sep 1, 2023
740aa0a
update
snnn Sep 1, 2023
28fd7a8
update
snnn Sep 1, 2023
b689b13
Merge remote-tracking branch 'origin/main' into snnn/update_docker_files
snnn Sep 5, 2023
6e136a7
Call set_tests_properties only when a test is added
snnn Sep 5, 2023
307a898
Merge remote-tracking branch 'origin/main' into snnn/update_docker_files
snnn Sep 5, 2023
7ada3d6
revert
snnn Sep 5, 2023
a645300
update
snnn Sep 5, 2023
207f117
revert
snnn Sep 5, 2023
688f751
Add error check
snnn Sep 5, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions dockerfiles/Dockerfile.arm32v7

This file was deleted.

17 changes: 0 additions & 17 deletions dockerfiles/Dockerfile.arm64

This file was deleted.

10 changes: 5 additions & 5 deletions dockerfiles/Dockerfile.source
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,17 @@
# --------------------------------------------------------------
# Dockerfile to run ONNXRuntime with source build for CPU

FROM ubuntu:22.04
FROM mcr.microsoft.com/cbl-mariner/base/python:3
MAINTAINER Changming Sun "chasun@microsoft.com"
ADD . /code

ENV DEBIAN_FRONTEND=noninteractive
RUN apt-get update && apt-get install -y --no-install-recommends python3-dev ca-certificates g++ python3-numpy gcc make git python3-setuptools python3-wheel python3-pip aria2 && aria2c -q -d /tmp -o cmake-3.26.3-linux-x86_64.tar.gz https://github.com/Kitware/CMake/releases/download/v3.26.3/cmake-3.26.3-linux-x86_64.tar.gz && tar -zxf /tmp/cmake-3.26.3-linux-x86_64.tar.gz --strip=1 -C /usr
RUN tdnf install -y tar ca-certificates build-essential python3-numpy cmake python3-setuptools python3-wheel python3-pip curl python3-devel
RUN /code/dockerfiles/scripts/install_cmake.sh

# Prepare onnxruntime repository & build onnxruntime
RUN cd /code && python3 -m pip install -r tools/ci_build/github/linux/docker/inference/x64/python/cpu/scripts/requirements.txt && /bin/bash ./build.sh --allow_running_as_root --skip_submodule_sync --config Release --build_wheel --update --build --parallel --cmake_extra_defines ONNXRUNTIME_VERSION=$(cat ./VERSION_NUMBER)

FROM ubuntu:22.04
FROM mcr.microsoft.com/cbl-mariner/base/python:3
COPY --from=0 /code/build/Linux/Release/dist /root
COPY --from=0 /code/dockerfiles/LICENSE-IMAGE.txt /code/LICENSE-IMAGE.txt
RUN apt-get update && apt-get install -y --no-install-recommends libstdc++6 ca-certificates python3-setuptools python3-wheel python3-pip unattended-upgrades && unattended-upgrade && python3 -m pip install /root/*.whl && rm -rf /root/*.whl
RUN tdnf install -y ca-certificates python3-setuptools python3-wheel python3-pip && python3 -m pip install /root/*.whl && rm -rf /root/*.whl
34 changes: 14 additions & 20 deletions dockerfiles/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@
- OpenVINO: [Dockerfile](Dockerfile.openvino), [Instructions](#openvino)
- TensorRT: [Dockerfile](Dockerfile.tensorrt), [Instructions](#tensorrt)
- VitisAI: [Dockerfile](Dockerfile.vitisai)

**Platforms**
- ARM 32v7: [Dockerfile](Dockerfile.arm32v7), [Instructions](#arm-3264)
- ARM 64: [Dockerfile](Dockerfile.arm64), [Instructions](#arm-3264)
- NVIDIA Jetson TX1/TX2/Nano/Xavier: [Dockerfile](Dockerfile.jetson), [Instructions](#nvidia-jetson-tx1tx2nanoxavier)

**Other**
Expand All @@ -22,38 +18,36 @@
# Instructions

## CPU
**Ubuntu 22.04, CPU, Python Bindings**
**Mariner 2.0, CPU, Python Bindings**

1. Update submodules
```
git submodule update --init
```

2. Build the docker image from the Dockerfile in this repository.
```
1. Build the docker image from the Dockerfile in this repository.
```bash
docker build -t onnxruntime-source -f Dockerfile.source ..
```

3. Run the Docker image
2. Run the Docker image

```
```bash
docker run -it onnxruntime-source
```

## CUDA
**Ubuntu 20.04, CUDA 11.4, CuDNN 8**
The docker file supports both x86_64 and ARM64(aarch64). You may use docker's "--platform" parameter to explictly specify which CPU architecture you want to build. For example:

Check notice on line 35 in dockerfiles/README.md

View workflow job for this annotation

GitHub Actions / misspell

[misspell] dockerfiles/README.md#L35

"explictly" is a misspelling of "explicitly"
Raw output
./dockerfiles/README.md:35:104: "explictly" is a misspelling of "explicitly"

1. Update submodules
```
git submodule update --init
```bash
docker build --platform linux/arm64/v8 -f Dockerfile.source
```
However, we cannot build the code for 32-bit ARM in such a way since a 32-bit compiler/linker might not have enough memory to generate the binaries.

2. Build the docker image from the Dockerfile in this repository.
## CUDA
**Ubuntu 22.04, CUDA 12.1, CuDNN 8**

1. Build the docker image from the Dockerfile in this repository.
```
docker build -t onnxruntime-cuda -f Dockerfile.cuda ..
```

3. Run the Docker image
2. Run the Docker image

```
docker run --gpus all -it onnxruntime-cuda
Expand Down
23 changes: 0 additions & 23 deletions dockerfiles/scripts/install_centos_arm64.sh

This file was deleted.

7 changes: 7 additions & 0 deletions dockerfiles/scripts/install_cmake.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
#!/bin/bash
mkdir -p /tmp/src
cd /tmp/src

Check warning on line 3 in dockerfiles/scripts/install_cmake.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] dockerfiles/scripts/install_cmake.sh#L3 <ShellCheck.SC2164>

Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
Raw output
./dockerfiles/scripts/install_cmake.sh:3:1: warning: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. (ShellCheck.SC2164)

echo "Installing cmake"
curl https://github.com/Kitware/CMake/releases/download/v3.27.1/cmake-3.27.1-linux-`uname -m`.tar.gz -sSL --retry 5 -o /tmp/src/cmake-3.27.1-linux-`uname -m`.tar.gz

Check warning on line 6 in dockerfiles/scripts/install_cmake.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] dockerfiles/scripts/install_cmake.sh#L6 <ShellCheck.SC2046>

Quote this to prevent word splitting.
Raw output
./dockerfiles/scripts/install_cmake.sh:6:84: warning: Quote this to prevent word splitting. (ShellCheck.SC2046)

Check notice on line 6 in dockerfiles/scripts/install_cmake.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] dockerfiles/scripts/install_cmake.sh#L6 <ShellCheck.SC2006>

Use $(...) notation instead of legacy backticks `...`.
Raw output
./dockerfiles/scripts/install_cmake.sh:6:84: info: Use $(...) notation instead of legacy backticks `...`. (ShellCheck.SC2006)

Check warning on line 6 in dockerfiles/scripts/install_cmake.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] dockerfiles/scripts/install_cmake.sh#L6 <ShellCheck.SC2046>

Quote this to prevent word splitting.
Raw output
./dockerfiles/scripts/install_cmake.sh:6:149: warning: Quote this to prevent word splitting. (ShellCheck.SC2046)

Check notice on line 6 in dockerfiles/scripts/install_cmake.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] dockerfiles/scripts/install_cmake.sh#L6 <ShellCheck.SC2006>

Use $(...) notation instead of legacy backticks `...`.
Raw output
./dockerfiles/scripts/install_cmake.sh:6:149: info: Use $(...) notation instead of legacy backticks `...`. (ShellCheck.SC2006)
tar -zxf /tmp/src/cmake-3.27.1-linux-`uname -m`.tar.gz --strip=1 -C /usr

Check warning on line 7 in dockerfiles/scripts/install_cmake.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] dockerfiles/scripts/install_cmake.sh#L7 <ShellCheck.SC2046>

Quote this to prevent word splitting.
Raw output
./dockerfiles/scripts/install_cmake.sh:7:38: warning: Quote this to prevent word splitting. (ShellCheck.SC2046)

Check notice on line 7 in dockerfiles/scripts/install_cmake.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] dockerfiles/scripts/install_cmake.sh#L7 <ShellCheck.SC2006>

Use $(...) notation instead of legacy backticks `...`.
Raw output
./dockerfiles/scripts/install_cmake.sh:7:38: info: Use $(...) notation instead of legacy backticks `...`. (ShellCheck.SC2006)
6 changes: 3 additions & 3 deletions dockerfiles/scripts/install_common_deps.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/bash
DEBIAN_FRONTEND=noninteractive

Check warning on line 2 in dockerfiles/scripts/install_common_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] dockerfiles/scripts/install_common_deps.sh#L2 <ShellCheck.SC2034>

DEBIAN_FRONTEND appears unused. Verify use (or export if used externally).
Raw output
./dockerfiles/scripts/install_common_deps.sh:2:1: warning: DEBIAN_FRONTEND appears unused. Verify use (or export if used externally). (ShellCheck.SC2034)
apt-get update && apt-get install -y --no-install-recommends \
wget \
zip \
Expand All @@ -21,6 +21,6 @@
rm -rf /opt/miniconda/pkgs

# Dependencies: cmake
wget --quiet https://github.com/Kitware/CMake/releases/download/v3.26.3/cmake-3.26.3-linux-x86_64.tar.gz
tar zxf cmake-3.26.3-linux-x86_64.tar.gz
snnn marked this conversation as resolved.
Show resolved Hide resolved
rm -rf cmake-3.26.3-linux-x86_64.tar.gz
wget --quiet https://github.com/Kitware/CMake/releases/download/v3.27.1/cmake-3.27.1-linux-x86_64.tar.gz
tar zxf cmake-3.27.1-linux-x86_64.tar.gz
rm -rf cmake-3.27.1-linux-x86_64.tar.gz
5 changes: 0 additions & 5 deletions dockerfiles/scripts/install_fedora_arm32.sh

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -14,22 +14,22 @@
echo "File '$path' already exists. Skipping download"
return 0
else
rm -rf $path

Check notice on line 17 in tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh#L17 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh:17:14: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
fi
fi

if [[ -f $uri ]]; then
echo "'$uri' is a file path, copying file to '$path'"
cp $uri $path

Check notice on line 23 in tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh#L23 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh:23:8: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)

Check notice on line 23 in tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh#L23 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh:23:13: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
return $?
fi

echo "Downloading $uri"
# Use aria2c if available, otherwise use curl
if command -v aria2c > /dev/null; then
aria2c -q -d $(dirname $path) -o $(basename $path) "$uri"

Check warning on line 30 in tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh#L30 <ShellCheck.SC2046>

Quote this to prevent word splitting.
Raw output
./tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh:30:18: warning: Quote this to prevent word splitting. (ShellCheck.SC2046)

Check notice on line 30 in tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh#L30 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh:30:28: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)

Check warning on line 30 in tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh#L30 <ShellCheck.SC2046>

Quote this to prevent word splitting.
Raw output
./tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh:30:38: warning: Quote this to prevent word splitting. (ShellCheck.SC2046)

Check notice on line 30 in tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh#L30 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh:30:49: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
else
curl "$uri" -sSL --retry $download_retries --retry-delay $retry_wait_time_seconds --create-dirs -o "$path" --fail

Check notice on line 32 in tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh#L32 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh:32:30: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)

Check notice on line 32 in tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh#L32 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh:32:62: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
fi

return $?
Expand All @@ -39,8 +39,8 @@
cd /tmp/src

echo "Installing cmake"
GetFile https://github.com/Kitware/CMake/releases/download/v3.26.3/cmake-3.26.3-linux-`uname -m`.tar.gz /tmp/src/cmake-3.26.3-linux-`uname -m`.tar.gz
tar -zxf /tmp/src/cmake-3.26.3-linux-`uname -m`.tar.gz --strip=1 -C /usr
GetFile https://github.com/Kitware/CMake/releases/download/v3.27.1/cmake-3.27.1-linux-`uname -m`.tar.gz /tmp/src/cmake-3.27.1-linux-`uname -m`.tar.gz

Check warning on line 42 in tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh#L42 <ShellCheck.SC2046>

Quote this to prevent word splitting.
Raw output
./tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh:42:87: warning: Quote this to prevent word splitting. (ShellCheck.SC2046)

Check notice on line 42 in tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh#L42 <ShellCheck.SC2006>

Use $(...) notation instead of legacy backticks `...`.
Raw output
./tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh:42:87: info: Use $(...) notation instead of legacy backticks `...`. (ShellCheck.SC2006)

Check warning on line 42 in tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh#L42 <ShellCheck.SC2046>

Quote this to prevent word splitting.
Raw output
./tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh:42:133: warning: Quote this to prevent word splitting. (ShellCheck.SC2046)

Check notice on line 42 in tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh#L42 <ShellCheck.SC2006>

Use $(...) notation instead of legacy backticks `...`.
Raw output
./tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh:42:133: info: Use $(...) notation instead of legacy backticks `...`. (ShellCheck.SC2006)
tar -zxf /tmp/src/cmake-3.27.1-linux-`uname -m`.tar.gz --strip=1 -C /usr

Check warning on line 43 in tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh#L43 <ShellCheck.SC2046>

Quote this to prevent word splitting.
Raw output
./tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh:43:38: warning: Quote this to prevent word splitting. (ShellCheck.SC2046)

Check notice on line 43 in tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh#L43 <ShellCheck.SC2006>

Use $(...) notation instead of legacy backticks `...`.
Raw output
./tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh:43:38: info: Use $(...) notation instead of legacy backticks `...`. (ShellCheck.SC2006)

echo "Installing Ninja"
GetFile https://github.com/ninja-build/ninja/archive/v1.10.0.tar.gz /tmp/src/ninja-linux.tar.gz
Expand All @@ -52,7 +52,7 @@
popd

echo "Installing Node.js"
CPU_ARCH=`uname -m`

Check notice on line 55 in tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh#L55 <ShellCheck.SC2006>

Use $(...) notation instead of legacy backticks `...`.
Raw output
./tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh:55:10: info: Use $(...) notation instead of legacy backticks `...`. (ShellCheck.SC2006)
if [[ "$CPU_ARCH" = "x86_64" ]]; then
NODEJS_ARCH=x64
elif [[ "$CPU_ARCH" = "aarch64" ]]; then
Expand All @@ -60,8 +60,8 @@
else
NODEJS_ARCH=$CPU_ARCH
fi
GetFile https://nodejs.org/dist/v16.14.2/node-v16.14.2-linux-${NODEJS_ARCH}.tar.gz /tmp/src/node-v16.14.2-linux-${NODEJS_ARCH}.tar.gz

Check notice on line 63 in tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh#L63 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh:63:62: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)

Check notice on line 63 in tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh#L63 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh:63:113: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
tar --strip 1 -xf /tmp/src/node-v16.14.2-linux-${NODEJS_ARCH}.tar.gz -C /usr

Check notice on line 64 in tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh#L64 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh:64:48: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)

# The Python version in CentOS 7's python3 package is no longer supported (3.6) so we will build Python from source.
echo "Installing Python"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,22 +14,22 @@
echo "File '$path' already exists. Skipping download"
return 0
else
rm -rf $path

Check notice on line 17 in tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh#L17 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh:17:14: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
fi
fi

if [[ -f $uri ]]; then
echo "'$uri' is a file path, copying file to '$path'"
cp $uri $path

Check notice on line 23 in tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh#L23 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh:23:8: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)

Check notice on line 23 in tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh#L23 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh:23:13: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
return $?
fi

echo "Downloading $uri"
# Use aria2c if available, otherwise use curl
if command -v aria2c > /dev/null; then
aria2c -q -d $(dirname $path) -o $(basename $path) "$uri"

Check warning on line 30 in tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh#L30 <ShellCheck.SC2046>

Quote this to prevent word splitting.
Raw output
./tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh:30:18: warning: Quote this to prevent word splitting. (ShellCheck.SC2046)

Check notice on line 30 in tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh#L30 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh:30:28: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)

Check warning on line 30 in tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh#L30 <ShellCheck.SC2046>

Quote this to prevent word splitting.
Raw output
./tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh:30:38: warning: Quote this to prevent word splitting. (ShellCheck.SC2046)

Check notice on line 30 in tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh#L30 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh:30:49: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
else
curl "$uri" -sSL --retry $download_retries --retry-delay $retry_wait_time_seconds --create-dirs -o "$path" --fail

Check notice on line 32 in tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh#L32 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh:32:30: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)

Check notice on line 32 in tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh#L32 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh:32:62: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
fi

return $?
Expand All @@ -39,8 +39,8 @@
cd /tmp/src

echo "Installing cmake"
GetFile https://github.com/Kitware/CMake/releases/download/v3.26.3/cmake-3.26.3-linux-`uname -m`.tar.gz /tmp/src/cmake-3.26.3-linux-`uname -m`.tar.gz
tar -zxf /tmp/src/cmake-3.26.3-linux-`uname -m`.tar.gz --strip=1 -C /usr
GetFile https://github.com/Kitware/CMake/releases/download/v3.27.1/cmake-3.27.1-linux-`uname -m`.tar.gz /tmp/src/cmake-3.27.1-linux-`uname -m`.tar.gz

Check warning on line 42 in tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh#L42 <ShellCheck.SC2046>

Quote this to prevent word splitting.
Raw output
./tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh:42:87: warning: Quote this to prevent word splitting. (ShellCheck.SC2046)

Check notice on line 42 in tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh#L42 <ShellCheck.SC2006>

Use $(...) notation instead of legacy backticks `...`.
Raw output
./tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh:42:87: info: Use $(...) notation instead of legacy backticks `...`. (ShellCheck.SC2006)

Check warning on line 42 in tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh#L42 <ShellCheck.SC2046>

Quote this to prevent word splitting.
Raw output
./tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh:42:133: warning: Quote this to prevent word splitting. (ShellCheck.SC2046)

Check notice on line 42 in tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh#L42 <ShellCheck.SC2006>

Use $(...) notation instead of legacy backticks `...`.
Raw output
./tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh:42:133: info: Use $(...) notation instead of legacy backticks `...`. (ShellCheck.SC2006)
tar -zxf /tmp/src/cmake-3.27.1-linux-`uname -m`.tar.gz --strip=1 -C /usr

Check warning on line 43 in tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh#L43 <ShellCheck.SC2046>

Quote this to prevent word splitting.
Raw output
./tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh:43:38: warning: Quote this to prevent word splitting. (ShellCheck.SC2046)

Check notice on line 43 in tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh#L43 <ShellCheck.SC2006>

Use $(...) notation instead of legacy backticks `...`.
Raw output
./tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh:43:38: info: Use $(...) notation instead of legacy backticks `...`. (ShellCheck.SC2006)

echo "Installing Ninja"
GetFile https://github.com/ninja-build/ninja/archive/v1.10.0.tar.gz /tmp/src/ninja-linux.tar.gz
Expand All @@ -52,7 +52,7 @@
popd

echo "Installing Node.js"
CPU_ARCH=`uname -m`

Check notice on line 55 in tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh#L55 <ShellCheck.SC2006>

Use $(...) notation instead of legacy backticks `...`.
Raw output
./tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh:55:10: info: Use $(...) notation instead of legacy backticks `...`. (ShellCheck.SC2006)
if [[ "$CPU_ARCH" = "x86_64" ]]; then
NODEJS_ARCH=x64
elif [[ "$CPU_ARCH" = "aarch64" ]]; then
Expand All @@ -60,8 +60,8 @@
else
NODEJS_ARCH=$CPU_ARCH
fi
GetFile https://nodejs.org/dist/v16.14.2/node-v16.14.2-linux-${NODEJS_ARCH}.tar.gz /tmp/src/node-v16.14.2-linux-${NODEJS_ARCH}.tar.gz

Check notice on line 63 in tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh#L63 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh:63:62: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)

Check notice on line 63 in tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh#L63 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh:63:113: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
tar --strip 1 -xf /tmp/src/node-v16.14.2-linux-${NODEJS_ARCH}.tar.gz -C /usr

Check notice on line 64 in tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh#L64 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tools/ci_build/github/linux/docker/inference/x64/default/cpu/scripts/install_deps.sh:64:48: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)

# The Python version in CentOS 7's python3 package is no longer supported (3.6) so we will build Python from source.
echo "Installing Python"
Expand Down
10 changes: 5 additions & 5 deletions tools/ci_build/github/linux/docker/scripts/install_os_deps.sh
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
#!/bin/bash
set -e -x

SCRIPT_DIR="$( dirname "${BASH_SOURCE[0]}" )"

Check warning on line 4 in tools/ci_build/github/linux/docker/scripts/install_os_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/scripts/install_os_deps.sh#L4 <ShellCheck.SC2034>

SCRIPT_DIR appears unused. Verify use (or export if used externally).
Raw output
./tools/ci_build/github/linux/docker/scripts/install_os_deps.sh:4:1: warning: SCRIPT_DIR appears unused. Verify use (or export if used externally). (ShellCheck.SC2034)
INSTALL_DEPS_DISTRIBUTED_SETUP=false

while getopts p:d:v:tmur parameter_Option
do case "${parameter_Option}"

Check warning on line 8 in tools/ci_build/github/linux/docker/scripts/install_os_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/scripts/install_os_deps.sh#L8 <ShellCheck.SC2220>

Invalid flags are not handled. Add a *) case.
Raw output
./tools/ci_build/github/linux/docker/scripts/install_os_deps.sh:8:4: warning: Invalid flags are not handled. Add a *) case. (ShellCheck.SC2220)
in
p) echo "Python version is no longer accepted as an input to this script. Ignoring the input argument -p.";;
d) DEVICE_TYPE=${OPTARG};;
Expand All @@ -32,22 +32,22 @@
echo "File '$path' already exists. Skipping download"
return 0
else
rm -rf $path

Check notice on line 35 in tools/ci_build/github/linux/docker/scripts/install_os_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/scripts/install_os_deps.sh#L35 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tools/ci_build/github/linux/docker/scripts/install_os_deps.sh:35:14: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
fi
fi

if [[ -f $uri ]]; then
echo "'$uri' is a file path, copying file to '$path'"
cp $uri $path

Check notice on line 41 in tools/ci_build/github/linux/docker/scripts/install_os_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/scripts/install_os_deps.sh#L41 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tools/ci_build/github/linux/docker/scripts/install_os_deps.sh:41:8: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)

Check notice on line 41 in tools/ci_build/github/linux/docker/scripts/install_os_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/scripts/install_os_deps.sh#L41 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tools/ci_build/github/linux/docker/scripts/install_os_deps.sh:41:13: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
return $?
fi

echo "Downloading $uri"
# Use aria2c if available, otherwise use curl
if command -v aria2c > /dev/null; then
aria2c -q -d $(dirname $path) -o $(basename $path) "$uri"

Check warning on line 48 in tools/ci_build/github/linux/docker/scripts/install_os_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/scripts/install_os_deps.sh#L48 <ShellCheck.SC2046>

Quote this to prevent word splitting.
Raw output
./tools/ci_build/github/linux/docker/scripts/install_os_deps.sh:48:18: warning: Quote this to prevent word splitting. (ShellCheck.SC2046)

Check notice on line 48 in tools/ci_build/github/linux/docker/scripts/install_os_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/scripts/install_os_deps.sh#L48 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tools/ci_build/github/linux/docker/scripts/install_os_deps.sh:48:28: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)

Check warning on line 48 in tools/ci_build/github/linux/docker/scripts/install_os_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/scripts/install_os_deps.sh#L48 <ShellCheck.SC2046>

Quote this to prevent word splitting.
Raw output
./tools/ci_build/github/linux/docker/scripts/install_os_deps.sh:48:38: warning: Quote this to prevent word splitting. (ShellCheck.SC2046)

Check notice on line 48 in tools/ci_build/github/linux/docker/scripts/install_os_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/scripts/install_os_deps.sh#L48 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tools/ci_build/github/linux/docker/scripts/install_os_deps.sh:48:49: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
else
curl "$uri" -sSL --retry $download_retries --retry-delay $retry_wait_time_seconds --create-dirs -o "$path" --fail

Check notice on line 50 in tools/ci_build/github/linux/docker/scripts/install_os_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/scripts/install_os_deps.sh#L50 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tools/ci_build/github/linux/docker/scripts/install_os_deps.sh:50:30: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)

Check notice on line 50 in tools/ci_build/github/linux/docker/scripts/install_os_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/scripts/install_os_deps.sh#L50 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tools/ci_build/github/linux/docker/scripts/install_os_deps.sh:50:62: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
fi

return $?
Expand All @@ -62,7 +62,7 @@
if [[ "$DISTRIBUTOR" = "CentOS" && $SYS_LONG_BIT = "64" ]]; then
LIBDIR="lib64"
else
LIBDIR="lib"

Check warning on line 65 in tools/ci_build/github/linux/docker/scripts/install_os_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/scripts/install_os_deps.sh#L65 <ShellCheck.SC2034>

LIBDIR appears unused. Verify use (or export if used externally).
Raw output
./tools/ci_build/github/linux/docker/scripts/install_os_deps.sh:65:3: warning: LIBDIR appears unused. Verify use (or export if used externally). (ShellCheck.SC2034)
fi
if [[ $SYS_LONG_BIT = "64" && "$GLIBC_VERSION" -gt "9" ]]; then
echo "Installing azcopy"
Expand All @@ -71,19 +71,19 @@
tar --strip 1 -xf /tmp/azcopy/azcopy.tar.gz -C /tmp/azcopy
cp /tmp/azcopy/azcopy /usr/bin
echo "Installing cmake"
GetFile https://github.com/Kitware/CMake/releases/download/v3.26.3/cmake-3.26.3-Linux-x86_64.tar.gz /tmp/src/cmake-3.26.3-Linux-x86_64.tar.gz
tar -zxf /tmp/src/cmake-3.26.3-Linux-x86_64.tar.gz --strip=1 -C /usr
GetFile https://github.com/Kitware/CMake/releases/download/v3.27.1/cmake-3.27.1-Linux-x86_64.tar.gz /tmp/src/cmake-3.27.1-Linux-x86_64.tar.gz
tar -zxf /tmp/src/cmake-3.27.1-Linux-x86_64.tar.gz --strip=1 -C /usr
echo "Installing Node.js"
GetFile https://nodejs.org/dist/v16.14.2/node-v16.14.2-linux-x64.tar.xz /tmp/src/node-v16.14.2-linux-x64.tar.xz
tar -xf /tmp/src/node-v16.14.2-linux-x64.tar.xz --strip=1 -C /usr
else
echo "Installing cmake"
GetFile https://github.com/Kitware/CMake/releases/download/v3.26.3/cmake-3.26.3.tar.gz /tmp/src/cmake-3.26.3.tar.gz
tar -xf /tmp/src/cmake-3.26.3.tar.gz -C /tmp/src
GetFile https://github.com/Kitware/CMake/releases/download/v3.27.1/cmake-3.27.1.tar.gz /tmp/src/cmake-3.27.1.tar.gz
tar -xf /tmp/src/cmake-3.27.1.tar.gz -C /tmp/src
pushd .
cd /tmp/src/cmake-3.26.3
cd /tmp/src/cmake-3.27.1
./bootstrap --prefix=/usr --parallel=$(getconf _NPROCESSORS_ONLN) --system-bzip2 --system-curl --system-zlib --system-expat

Check warning on line 85 in tools/ci_build/github/linux/docker/scripts/install_os_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/scripts/install_os_deps.sh#L85 <ShellCheck.SC2046>

Quote this to prevent word splitting.
Raw output
./tools/ci_build/github/linux/docker/scripts/install_os_deps.sh:85:40: warning: Quote this to prevent word splitting. (ShellCheck.SC2046)
make -j$(getconf _NPROCESSORS_ONLN)

Check warning on line 86 in tools/ci_build/github/linux/docker/scripts/install_os_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/scripts/install_os_deps.sh#L86 <ShellCheck.SC2046>

Quote this to prevent word splitting.
Raw output
./tools/ci_build/github/linux/docker/scripts/install_os_deps.sh:86:10: warning: Quote this to prevent word splitting. (ShellCheck.SC2046)
make install
popd
fi
Expand All @@ -91,12 +91,12 @@
cd /tmp/src

if ! [ -x "$(command -v protoc)" ]; then
source ${0/%install_os_deps\.sh/install_protobuf\.sh}

Check warning on line 94 in tools/ci_build/github/linux/docker/scripts/install_os_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/scripts/install_os_deps.sh#L94 <ShellCheck.SC1090>

ShellCheck can't follow non-constant source. Use a directive to specify location.
Raw output
./tools/ci_build/github/linux/docker/scripts/install_os_deps.sh:94:10: warning: ShellCheck can't follow non-constant source. Use a directive to specify location. (ShellCheck.SC1090)

Check notice on line 94 in tools/ci_build/github/linux/docker/scripts/install_os_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/scripts/install_os_deps.sh#L94 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tools/ci_build/github/linux/docker/scripts/install_os_deps.sh:94:10: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
fi

if [ $DEVICE_TYPE = "gpu" ]; then

Check notice on line 97 in tools/ci_build/github/linux/docker/scripts/install_os_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/scripts/install_os_deps.sh#L97 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tools/ci_build/github/linux/docker/scripts/install_os_deps.sh:97:6: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
if [[ $INSTALL_DEPS_DISTRIBUTED_SETUP = true ]]; then
source ${0/%install_os_deps.sh/install_openmpi.sh}

Check warning on line 99 in tools/ci_build/github/linux/docker/scripts/install_os_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/scripts/install_os_deps.sh#L99 <ShellCheck.SC1090>

ShellCheck can't follow non-constant source. Use a directive to specify location.
Raw output
./tools/ci_build/github/linux/docker/scripts/install_os_deps.sh:99:12: warning: ShellCheck can't follow non-constant source. Use a directive to specify location. (ShellCheck.SC1090)

Check notice on line 99 in tools/ci_build/github/linux/docker/scripts/install_os_deps.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tools/ci_build/github/linux/docker/scripts/install_os_deps.sh#L99 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tools/ci_build/github/linux/docker/scripts/install_os_deps.sh:99:12: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
fi
fi

Expand Down
Loading