Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DML EP] Add missing member initializer DmlGraphNodeCreateInfo::nodeCount #17505

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

kazssym
Copy link
Contributor

@kazssym kazssym commented Sep 12, 2023

Description

This adds a missing member initialization.

Motivation and Context

It caused an access violation in Dml::GraphDescBuilder::BuildGraphDesc.

@kazssym kazssym marked this pull request as ready for review September 12, 2023 01:09
@kazssym kazssym changed the title Add missing member init [DML EP] Add missing member initializer Sep 12, 2023
@fdwr
Copy link
Contributor

fdwr commented Sep 14, 2023

@sumitsays

@fdwr fdwr requested a review from sumitsays September 14, 2023 00:24
@fdwr fdwr changed the title [DML EP] Add missing member initializer [DML EP] Add missing member initializer DmlGraphNodeCreateInfo::nodeCount Sep 14, 2023
@fdwr
Copy link
Contributor

fdwr commented Sep 14, 2023

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline, Linux QNN CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Sep 14, 2023

/azp run Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows ARM64 QNN CI Pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed, ONNX Runtime React Native CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 8 pipeline(s).

@fdwr
Copy link
Contributor

fdwr commented Sep 14, 2023

/azp run Windows x64 QNN CI Pipeline, ONNX Runtime Web CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@fdwr
Copy link
Contributor

fdwr commented Sep 14, 2023

/azp run Windows x64 QNN CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@fdwr fdwr merged commit 5ed5f13 into microsoft:main Sep 15, 2023
70 checks passed
snnn added a commit that referenced this pull request Nov 2, 2023
Cherry-pick PRs: 
#18026 
#17912 
#17901 “2 lines added whitespace errors when cherry-picking"
#17293 
#17364 
#17505 
#17885

This PR contains all the cherry-picks for the patch release except:
1. The PRs marked with sdxl_llama
2. #17772 which has a merge conflict.

---------

Co-authored-by: Chi Lo <Chi.Lo@microsoft.com>
Co-authored-by: Chi Lo <54722500+chilo-ms@users.noreply.github.com>
Co-authored-by: Scott McKay <Scott.McKay@microsoft.com>
Co-authored-by: Baiju Meswani <bmeswani@microsoft.com>
Co-authored-by: Kaz Nishimura <kazssym@linuxfront.com>
Co-authored-by: Scott McKay <skottmckay@gmail.com>
kleiti pushed a commit to kleiti/onnxruntime that referenced this pull request Mar 22, 2024
…ount (microsoft#17505)

### Description
<!-- Describe your changes. -->

This adds a missing member initialization.

### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->

It caused an access violation in
`Dml::GraphDescBuilder::BuildGraphDesc`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants