[web] remove xnnpack from web backends #19116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guschmue
previously approved these changes
Jan 12, 2024
snnn
previously approved these changes
Jan 12, 2024
guschmue
approved these changes
Jan 13, 2024
snnn
approved these changes
Jan 13, 2024
mszhanyi
pushed a commit
that referenced
this pull request
Jan 15, 2024
### Description XNNPACK is already disabled in web assembly build. This change removes the xnnpack backend registration in JS.
|
Hi, may I know the reason of removing xnnpack backend from web? Is it a temporary workaround for any issue or does ONNX Runtime Web decide to remove xnnpack in the future? |
The major reason is that we didn't see significant performance benefit from using XNNPACK comparing to the default ONNX Runtime CPU EP. |
siweic0
pushed a commit
to siweic0/onnxruntime-web
that referenced
this pull request
May 9, 2024
### Description XNNPACK is already disabled in web assembly build. This change removes the xnnpack backend registration in JS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
XNNPACK is already disabled in web assembly build. This change removes the xnnpack backend registration in JS.