Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[js] changes to allow Float16Array if any polyfill is available #19305

Merged
merged 3 commits into from
Feb 21, 2024
Merged

[js] changes to allow Float16Array if any polyfill is available #19305

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf4fbbe
[js] changes to allow Float16Array if any polyfill is available
fs-eire Jan 29, 2024
f7e43f5
fix lint error
fs-eire Jan 29, 2024
e97ea2c
fix test
fs-eire Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix test
  • Loading branch information
@fs-eire
fs-eire committed Jan 30, 2024
commit e97ea2c66f8cb2a488a1cb372fea94dc70799040
2 changes: 1 addition & 1 deletion js/common/lib/tensor-impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ export class Tensor implements TensorInterface {
throw new TypeError(`Unsupported tensor type: ${arg0}.`);
}
if (Array.isArray(arg1)) {
if (arg0 === 'float16' && typedArrayConstructor.prototype instanceof Uint16Array) {
if (arg0 === 'float16' && typedArrayConstructor === Uint16Array) {
// When no Float16Array polyfill is used, we cannot create 'float16' tensor from number array.
//
// Throw error here because when user try to use number array as data,
Expand Down
Loading