Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JS/WebGPU] Preserve zero size input tensor dims. #19737

Merged
merged 12 commits into from
Mar 8, 2024
Merged

[JS/WebGPU] Preserve zero size input tensor dims. #19737

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
da6e9f5
Preserve zero size input tensor dims.
satyajandhyala Mar 1, 2024
ae01d11
Use adjustedAxis instead of axis
satyajandhyala Mar 1, 2024
2c0d67c
Refactor; add more tests.
satyajandhyala Mar 1, 2024
ce6a004
Moved the new concat test cases from concat.jsonc to concat_zero-size…
satyajandhyala Mar 1, 2024
51c83d7
Removed calculateOutputShape function.
satyajandhyala Mar 4, 2024
2bfc23e
Removed special case handling of all inputs zero-sized
satyajandhyala Mar 5, 2024
e8fb4d2
Use adjusted axis to validate.
satyajandhyala Mar 5, 2024
f19ece3
Rollback code allowing zero-sized input non-concat axes dims mismatch…
satyajandhyala Mar 6, 2024
c0fab59
Keep the variable name adjustedAxis
satyajandhyala Mar 6, 2024
ed048b0
Removed referenceInput.
satyajandhyala Mar 7, 2024
971b612
Fixed comment
satyajandhyala Mar 7, 2024
adfca56
Check if the axis is with in the range.
satyajandhyala Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use adjusted axis to validate.
  • Loading branch information
@satyajandhyala
satyajandhyala committed Mar 5, 2024
commit e8fb4d28b01927f7238ffb9dc8d026598ceeb53f
2 changes: 1 addition & 1 deletion js/web/lib/wasm/jsep/webgpu/ops/concat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,9 +155,9 @@ export const concat = (context: ComputeContext, attributes: ConcatAttributes): v
(maxRankIndex, input, index, array) => input.dims > array[maxRankIndex].dims ? index : maxRankIndex, 0);
}

validateInputs(inputs, referenceIndex, attributes.axis);
const inputShape = inputs[referenceIndex].dims;
const adjustedAxis = attributes.axis + (attributes.axis < 0 ? inputShape.length : 0);
validateInputs(inputs, referenceIndex, adjustedAxis);
const outputShape = inputShape.slice();
outputShape[adjustedAxis] =
inputs.reduce((sum, input) => sum + (input.dims.length > adjustedAxis ? input.dims[adjustedAxis] : 0), 0);
Expand Down
Loading