[WebNN EP] Avoid reinit JSEP #19755
Closed
[WebNN EP] Avoid reinit JSEP #19755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cc/ @gyagp |
gyagp
reviewed
Mar 4, 2024
| // perform WebGPU availability check | ||
| if (typeof navigator === 'undefined' || !navigator.gpu) { | ||
| throw new Error('WebGPU is not supported in current environment'); | ||
| } | ||
| if (epName === 'webnn' && (typeof navigator === 'undefined' || !(navigator as any).ml)) { |
There was a problem hiding this comment.
I agree. I checked his PR which doesn't touch the initialization of JSEP. @fs-eire, will you handle it as well? You know we are not familiar with JSEP, the logic related to WebGPU is combined quite closely with JSEP, it's complicated for us to separate them.
There was a problem hiding this comment.
Added support for WebNN in #19735
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
If the user creates both WebNN EP and WebGPU EP in the same scope, JSEP will be initialized twice and cause error of redefinition.