Apply suggestions from code review

Co-authored-by: kunal-vaishnavi <115581922+kunal-vaishnavi@users.noreply.github.com>

onnxruntime/python/tools/transformers/models/whisper/whisper_encoder_decoder_init.py

@@ -133,7 +133,6 @@ def export_onnx(
         )
         input_list = inputs.to_list()
 
-        # TODO : Investigate whether copy of model if needed
         out = model(inputs.encoder_input_ids, inputs.decoder_input_ids, remove_hooks=True)
         present = out[2]
         present_names = PastKeyValuesHelper.get_input_names(present, encoder=True)

onnxruntime/python/tools/transformers/models/whisper/whisper_helper.py

@@ -388,7 +388,7 @@ def select_transcription_options(
         batch_size: int,
         prompt_mode: bool,
     ):
-        if batch_size > 1 and prompt_mode is True:
+        if batch_size > 1 and prompt_mode:
             expected_transcription_no_comma_prompt1 = " John has doubts whether Sir Frederick Layton's work is really Greek after all and can discover in it but little of Rocky I"
             expected_transcription_misspelled_prompt1 = " John has doubts whether Sir Frederick Latins work is really Greek after all and can discover in it but little of Rocky I"
             expected_transcription_no_comma_prompt2 = " Maria has grave doubts whether Sir Frederick Layton's work is really Greek after all and can discover in it but little of Rocky"
@@ -432,8 +432,8 @@ def verify_onnx(
         pt_model = WhisperForConditionalGeneration.from_pretrained(
             model_name_or_path, cache_dir=cache_dir, **extra_kwargs
         ).to(device)
-        processor = WhisperProcessor.from_pretrained(model_name_or_path)
-        config = WhisperConfig.from_pretrained(model_name_or_path)
+        processor = WhisperProcessor.from_pretrained(model_name_or_path, cache_dir=cache_dir)
+        config = WhisperConfig.from_pretrained(model_name_or_path, cache_dir=cache_dir)
 
         inputs, pt_transcription, pt_outputs, decoder_prompt_ids = WhisperHelper.pt_transcription_for_verify_onnx(
             processor,

onnxruntime/python/tools/transformers/models/whisper/whisper_openai_helper.py

@@ -77,7 +77,7 @@ def forward(
         ]
 
         # Remove forward hooks to avoid model cloning step
-        if hooks is not None and remove_hooks is True:
+        if hooks is not None and remove_hooks:
             self.kv_cache = {}
             for hook in hooks:
                 hook.remove()