Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Apple framework] Fix minimal build with training enabled. #19858

Merged
merged 4 commits into from
Mar 12, 2024

Conversation

edgchen1
Copy link
Contributor

Description

Fix some linker errors that come up when integrating the onnxruntime-training-c pod into another Xcode project. The problematic configuration is a minimal build with training APIs enabled.

  • training_op_defs.o had some unresolved references to ONNX functions. It should not be included at all in a minimal build.
  • tree_ensemble_helper.o also had unresolved references to ONNX ParseData. The containing function is unused in a minimal build.

Also added a test to cover this configuration.

Motivation and Context

Fix build issue.

@edgchen1 edgchen1 marked this pull request as ready for review March 12, 2024 01:23
@edgchen1 edgchen1 requested a review from a team as a code owner March 12, 2024 01:23
@edgchen1 edgchen1 requested a review from YUNQIUGUO March 12, 2024 01:44
@edgchen1 edgchen1 merged commit 860eb76 into main Mar 12, 2024
93 of 95 checks passed
@edgchen1 edgchen1 deleted the edgchen1/fix_minimal_training_build branch March 12, 2024 18:33
YUNQIUGUO pushed a commit that referenced this pull request Mar 21, 2024
Fix some linker errors that come up when integrating the onnxruntime-training-c pod into another Xcode project. The problematic configuration is a minimal build with training APIs enabled.
- training_op_defs.o had some unresolved references to ONNX functions. It should not be included at all in a minimal build.
- tree_ensemble_helper.o also had unresolved references to ONNX ParseData. The containing function is unused in a minimal build.

Added a test to cover this configuration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants