Add support for SGD optimizer in minimal build #19901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baijumeswani
added
the
training
AdamLouly
reviewed
Mar 13, 2024
pengwa
reviewed
Mar 14, 2024
pengwa
previously approved these changes
Mar 14, 2024
pengwa
reviewed
Mar 14, 2024
AdamLouly
previously approved these changes
Mar 14, 2024
pengwa
approved these changes
Mar 14, 2024
AdamLouly
approved these changes
Mar 14, 2024
baijumeswani
deleted the
baijumeswani/optimizer-support-on-device-training
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the minimal build does assumes that the given optimizer is always of AdamW type.
This pull-request correctly reads the optimizer node from the session state and is able to distinguish between the two optimizer types.
This pull-request also allows users to customize their optimizer model by passing in the approriate custom onnxblock to the
generate_artifactsmethod.